[release-4.10] Bug 2106838: remove broken thread-safety (#2697) #340
Conversation
The thread-safety logic is flawed and can prevent Operator resources from being reconciled when component resources are updated. It also ensures idempotence when enqueuing a resource for reconciliation; In other words, enqueuing no-ops if the given resource is already in the queue. The underlying queue will ensure a reconciler never races itself when processing a given resource event. Signed-off-by: Nick Hale <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 3807cc1a01619ddf857009c72ca1712746e8fc01
|
@tylerslaton: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tylerslaton
changed the title
tylerslaton
changed the title
|
/bugzilla refresh |
|
@tylerslaton: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-urgent
|
@tylerslaton: This pull request references Bugzilla bug 2106838, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tylerslaton: This pull request references Bugzilla bug 2106838, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
Looks good to me, details: https://bugzilla.redhat.com/show_bug.cgi?id=2106838#c2 |
openshift-ci
bot
added
the
qe-approved
|
/retest-required |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
changed the title
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan, tylerslaton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@tylerslaton: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick-approved |
|
@jianzhangbjz You may need to try |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
Ah, yes, sorry, my type mistake. |
|
@tylerslaton: All pull requests linked via external trackers have merged: Bugzilla bug 2106838 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.9 |
|
@perdasilva: new pull request created: #372 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
Backporting the fix for Bug 2015023 into 4.10.
Original commit
The thread-safety logic is flawed and can prevent Operator resources
from being reconciled when component resources are updated. It also
ensures idempotence when enqueuing a resource for reconciliation; In
other words, enqueuing no-ops if the given resource is already in the queue.
The underlying queue will ensure a reconciler never races itself when
processing a given resource event.
Signed-off-by: Nick Hale [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 3807cc1a01619ddf857009c72ca1712746e8fc01