OCPBUGS-570: [release-4.9] remove broken thread-safety (#2697) #372

openshift-cherrypick-robot · 2022-08-24T07:37:24Z

This is an automated cherry-pick of #340

/assign perdasilva

The thread-safety logic is flawed and can prevent Operator resources from being reconciled when component resources are updated. It also ensures idempotence when enqueuing a resource for reconciliation; In other words, enqueuing no-ops if the given resource is already in the queue. The underlying queue will ensure a reconciler never races itself when processing a given resource event. Signed-off-by: Nick Hale <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 3807cc1a01619ddf857009c72ca1712746e8fc01

openshift-ci · 2022-08-24T07:37:37Z

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 2106838 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


response code 401 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Bug 2106838: remove broken thread-safety (#2697)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-08-24T10:28:01Z

/retest

perdasilva · 2022-08-24T11:17:09Z

/retest

perdasilva · 2022-08-24T16:35:58Z

/retest

openshift-ci · 2022-08-24T19:59:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

perdasilva · 2022-08-25T07:08:16Z

/label backport-risk-assessed

perdasilva · 2022-08-25T07:19:35Z

/retitle OCPBUGS-570: [release-4.9] remove broken thread-safety (#2697)

openshift-ci · 2022-08-25T07:19:39Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-570: [release-4.9] remove broken thread-safety (#2697)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-08-25T07:20:07Z

/retitle OCPBUGS-570: [release-4.9] remove broken thread-safety (#2697)

openshift-ci · 2022-08-25T07:20:15Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-570: [release-4.9] remove broken thread-safety (#2697)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-08-25T07:20:16Z

@openshift-cherrypick-robot: This pull request references [Jira Issue OCPBUGS-570](https://issues.redhat.com//browse/OCPBUGS-570), which is invalid:

expected [Jira Issue OCPBUGS-570](https://issues.redhat.com//browse/OCPBUGS-570) to depend on a bug targeting a version in 4.10.0, 4.10.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #340

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-08-25T07:23:30Z

/jira refresh

openshift-ci-robot · 2022-08-25T07:23:36Z

@perdasilva: This pull request references [Jira Issue OCPBUGS-570](https://issues.redhat.com//browse/OCPBUGS-570), which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.9.z) matches configured target version for branch (4.9.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST)
dependent bug [Jira Issue OCPBUGS-571](https://issues.redhat.com//browse/OCPBUGS-571) is in the state Closed (Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE))
dependent [Jira Issue OCPBUGS-571](https://issues.redhat.com//browse/OCPBUGS-571) targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-08-25T07:24:46Z

/override bugzilla/valid-bug

openshift-ci · 2022-08-25T07:26:54Z

@perdasilva: perdasilva unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

In response to this:

/override bugzilla/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-09-12T10:50:05Z

/label cherry-pick-approved

openshift-ci · 2022-09-12T10:50:07Z

@perdasilva: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2022-09-13T03:46:43Z

/label qe-approved
/label cherry-pick-approved

jianzhangbjz · 2022-09-13T03:49:53Z

/label cherry-pick-approved

openshift-ci-robot · 2022-09-13T06:14:40Z

/retest-required

Remaining retests: 0 against base HEAD 0e015dd and 2 for PR HEAD 17e48e7 in total

perdasilva · 2022-09-13T07:09:46Z

/retest

jianzhangbjz · 2022-09-15T02:21:49Z

/test e2e-upgrade

jianzhangbjz · 2022-09-15T06:59:37Z

/test e2e-upgrade

perdasilva · 2022-09-19T07:35:25Z

/retest

timflannagan · 2022-09-20T20:17:27Z

/retest

openshift-ci · 2022-09-20T22:54:47Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-09-20T23:00:03Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#372

Jira Issue OCPBUGS-570 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #340

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: api Upstream-commit: a78f80ac29d5c8d4980fa75e893f746829ae59c0

openshift-ci bot assigned perdasilva Aug 24, 2022

openshift-cherrypick-robot mentioned this pull request Aug 24, 2022

[release-4.10] Bug 2106838: remove broken thread-safety (#2697) #340

Merged

openshift-ci bot requested review from anik120 and dinhxuanvu August 24, 2022 07:38

timflannagan approved these changes Aug 24, 2022

View reviewed changes

openshift-ci bot assigned timflannagan Aug 24, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 25, 2022

openshift-ci bot changed the title ~~[release-4.9] Bug 2106838: remove broken thread-safety (#2697)~~ [OCPBUGS-570](https://issues.redhat.com//browse/OCPBUGS-570): [release-4.9] remove broken thread-safety (#2697) Aug 25, 2022

openshift-ci bot changed the title ~~[OCPBUGS-570](https://issues.redhat.com//browse/OCPBUGS-570): [release-4.9] remove broken thread-safety (#2697)~~ OCPBUGS-570: [release-4.9] remove broken thread-safety (#2697) Aug 25, 2022

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Aug 25, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 25, 2022

openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Sep 13, 2022

openshift-merge-robot merged commit e6a262f into openshift:release-4.9 Sep 20, 2022

perdasilva mentioned this pull request Jan 15, 2025

NO-ISSUE: Manual Synchronize From Upstream Repositories #933

Merged

OCPBUGS-570: [release-4.9] remove broken thread-safety (#2697) #372

OCPBUGS-570: [release-4.9] remove broken thread-safety (#2697) #372

Uh oh!

Conversation

openshift-cherrypick-robot commented Aug 24, 2022

Uh oh!

openshift-ci bot commented Aug 24, 2022

Uh oh!

perdasilva commented Aug 24, 2022

Uh oh!

perdasilva commented Aug 24, 2022

Uh oh!

perdasilva commented Aug 24, 2022

Uh oh!

openshift-ci bot commented Aug 24, 2022

Uh oh!

perdasilva commented Aug 25, 2022

Uh oh!

perdasilva commented Aug 25, 2022

Uh oh!

openshift-ci bot commented Aug 25, 2022

Uh oh!

perdasilva commented Aug 25, 2022 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 25, 2022 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

perdasilva commented Aug 25, 2022

Uh oh!

openshift-ci-robot commented Aug 25, 2022 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

perdasilva commented Aug 25, 2022

Uh oh!

openshift-ci bot commented Aug 25, 2022

Uh oh!

perdasilva commented Sep 12, 2022

Uh oh!

openshift-ci bot commented Sep 12, 2022

Uh oh!

jianzhangbjz commented Sep 13, 2022

Uh oh!

jianzhangbjz commented Sep 13, 2022

Uh oh!

openshift-ci-robot commented Sep 13, 2022

Uh oh!

perdasilva commented Sep 13, 2022

Uh oh!

jianzhangbjz commented Sep 15, 2022

Uh oh!

jianzhangbjz commented Sep 15, 2022

Uh oh!

perdasilva commented Sep 19, 2022

Uh oh!

timflannagan commented Sep 20, 2022

Uh oh!

openshift-ci bot commented Sep 20, 2022

Uh oh!

openshift-ci-robot commented Sep 20, 2022

Uh oh!

Uh oh!

perdasilva commented Aug 25, 2022 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Aug 25, 2022 •

edited

Loading

openshift-ci-robot commented Aug 25, 2022 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 25, 2022 •

edited by openshift-ci bot

Loading