Skip to content

OCPBUGS-1004: dump descriptive source info on error instead of the source data (#1021) #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

OCPBUGS-1004: dump descriptive source info on error instead of the source data (#1021) #380

merged 1 commit into from
Sep 9, 2022
+26 −10

Conversation

grokspawn
Copy link
Contributor

Signed-off-by: Jordan Keister [email protected]
Upstream-commit: a3c883e9beee343bd55fd73c1447ea5e98459951
Upstream-repository: operator-registry

@grokspawn
dump descriptive source info on error instead of the source data (#1021)
bdfd23e 
Signed-off-by: Jordan Keister <[email protected]>
Upstream-commit: a3c883e9beee343bd55fd73c1447ea5e98459951
Upstream-repository: operator-registry
@openshift-ci openshift-ci bot requested review from awgreene and exdx September 8, 2022 17:55
@grokspawn
Copy link
Contributor Author

/hold for qe-approved label

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
@grokspawn grokspawn changed the title OCPBUGS-1004 dump descriptive source info on error instead of the source data (#1021) OCPBUGS-1004: dump descriptive source info on error instead of the source data (#1021) Sep 8, 2022
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 8, 2022
@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-1004, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Signed-off-by: Jordan Keister [email protected]
Upstream-commit: a3c883e9beee343bd55fd73c1447ea5e98459951
Upstream-repository: operator-registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 8, 2022
@grokspawn
Copy link
Contributor Author

/test e2e-upgrade
/test e2e-gcp-ovn

@Xia-Zhao-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 9, 2022
@grokspawn
Copy link
Contributor Author

/test e2e-gcp-ovn

@grokspawn
Copy link
Contributor Author

/hold cancel
got qe-approved label

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2022
@grokspawn
Copy link
Contributor Author

/test e2e-gcp-ovn

dinhxuanvu
dinhxuanvu approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, grokspawn, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 97782e6 into openshift:master Sep 9, 2022
@openshift-ci-robot
Copy link

@grokspawn: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1004 has been moved to the MODIFIED state.

In response to this:

Signed-off-by: Jordan Keister [email protected]
Upstream-commit: a3c883e9beee343bd55fd73c1447ea5e98459951
Upstream-repository: operator-registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn grokspawn deleted the opm-semver-veneer-error-msg branch September 9, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@timflannagan timflannagan timflannagan approved these changes

@awgreene awgreene Awaiting requested review from awgreene

@exdx exdx Awaiting requested review from exdx

Assignees

@dinhxuanvu dinhxuanvu

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grokspawn @openshift-ci-robot @Xia-Zhao-rh @dinhxuanvu @timflannagan @openshift-merge-robot