OCPBUGS-1004: (bug) semver veneer render: dump descriptive source info on error instead of the source data

[grokspawn]

Signed-off-by: Jordan Keister [email protected]

Description of the change:

when we deduce the input type, retain a descriptor of the type for use in future error messages

Motivation for the change:

previously, failed render attempt would output the input filename to let the user know where the error arose. when we expanded input to include stdin we rescoped to a datatype which is not meaningful when printed as part of the user message

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci-robot]

@grokspawn: This pull request references Jira Issue OCPBUGS-1004, which is invalid:

• expected the bug to target the "4.12.0" version, but it targets "4.12" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Signed-off-by: Jordan Keister [email protected]

Description of the change:

when we deduce the input type, retain a descriptor of the type for use in future error messages

Motivation for the change:

previously, failed render attempt would output the input filename to let the user know where the error arose. when we expanded input to include stdin we rescoped to a datatype which is not meaningful when printed as part of the user message

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [grokspawn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #1021 (0d5b545) into master (f45718e) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0d5b545 differs from pull request most recent head 9379c57. Consider uploading reports for the commit 9379c57 to get more accurate results

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
- Coverage   51.68%   51.66%   -0.02%     
==========================================
  Files         102      102              
  Lines        9164     9164              
==========================================
- Hits         4736     4735       -1     
- Misses       3520     3521       +1     
  Partials      908      908              

Impacted Files	Coverage Δ
alpha/veneer/semver/semver.go	60.00% <0.00%> (-0.50%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[grokspawn]

/jira refresh

[openshift-ci-robot]

@grokspawn: This pull request references Jira Issue OCPBUGS-1004, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.0) matches configured target version for branch (4.12.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oceanc80]

/lgtm

[openshift-ci-robot]

@grokspawn: All pull requests linked via external trackers have merged:

• operator-framework/operator-registry#1021

Jira Issue OCPBUGS-1004 has been moved to the MODIFIED state.

In response to this:

Signed-off-by: Jordan Keister [email protected]

Description of the change:

when we deduce the input type, retain a descriptor of the type for use in future error messages

Motivation for the change:

previously, failed render attempt would output the input filename to let the user know where the error arose. when we expanded input to include stdin we rescoped to a datatype which is not meaningful when printed as part of the user message

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.