Skip to content

[release-4.12] OCPBUGS-6260: Catalog, fatal error: concurrent map read and map write #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[release-4.12] OCPBUGS-6260: Catalog, fatal error: concurrent map read and map write #436

wants to merge 2 commits into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #429

/assign awgreene

@dtfranz
OCPBUGS-5523: Catalog, fatal error: concurrent map read and map write…
389142e 
… (#2913)

* protected subscriptionSyncCounters access to prevent concurrent map writes

Signed-off-by: Daniel Franz <[email protected]>

* organize map and mutex into single struct

Signed-off-by: Daniel Franz <[email protected]>

* initialize struct

Signed-off-by: Daniel Franz <[email protected]>

* use RWMutex to allow concurrent reads

Signed-off-by: Daniel Franz <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 2a49a4dddeb3e0fc38b44925bf9bd0d3931d4ff4
@dtfranz
update vendoring
79a0fff 
Signed-off-by: dtfranz <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 1, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-5523 with correct target version. Retitling PR to link to clone:
/retitle [release-4.12] OCPBUGS-6260: Catalog, fatal error: concurrent map read and map write

In response to this:

This is an automated cherry-pick of #429

/assign awgreene

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-5523: Catalog, fatal error: concurrent map read and map write [release-4.12] OCPBUGS-6260: Catalog, fatal error: concurrent map read and map write Feb 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-6260: Catalog, fatal error: concurrent map read and map write

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 1, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-6260, which is invalid:

  • expected dependent Jira Issue OCPBUGS-5523 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #429

/assign awgreene

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign anik120 for approval by writing /assign @anik120 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@awgreene
Copy link
Contributor

awgreene commented Feb 2, 2023

/retest

@awgreene
Copy link
Contributor

awgreene commented Feb 2, 2023 •
edited
Loading

/hold
Waiting on #438

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 79a0fff link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dtfranz dtfranz mentioned this pull request Feb 3, 2023
Closed
@awgreene
Copy link
Contributor

awgreene commented Feb 6, 2023

/close
Closed in favor of #440

@openshift-ci openshift-ci bot closed this Feb 6, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-6260. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #429

/assign awgreene

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

@awgreene: Closed this PR.

In response to this:

/close
Closed in favor of #440

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@awgreene awgreene

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @awgreene @dtfranz