Skip to content

OPECO-2646: exclude bundles with olm.deprecated property when rendering #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2023
Merged

OPECO-2646: exclude bundles with olm.deprecated property when rendering #463

merged 2 commits into from
Mar 7, 2023

Conversation

perdasilva
Copy link
Contributor

  • exclude bundles with olm.deprecated property when rendering
  • Exclude bundles based on the property type and not value

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 7, 2023 •
edited by openshift-ci bot
Loading

@perdasilva: This pull request references OPECO-2646 which is a valid jira issue.

In response to this:

  • exclude bundles with olm.deprecated property when rendering
  • Exclude bundles based on the property type and not value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 7, 2023
@openshift-ci openshift-ci bot requested review from ankitathomas and grokspawn March 7, 2023 08:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023
@perdasilva perdasilva force-pushed the exclude_deprecated branch from cff56c9 to a9efb9e Compare March 7, 2023 08:59
@rashmigottipati @perdasilva
OPECO-2646: exclude bundles with olm.deprecated property when rende…
67cc870 
…ring (#1063)

* exclude bundles with `olm.deprecated` property when rendering

Signed-off-by: Rashmi Gottipati <[email protected]>

* Exclude bundles based on the property type and not value

Signed-off-by: Rashmi Gottipati <[email protected]>

---------

Signed-off-by: Rashmi Gottipati <[email protected]>
Upstream-repository: operator-registry
Upstream-commit: 0aeffa3f44f5e36bd2c0bcc63a94eda000a5f257
@perdasilva perdasilva force-pushed the exclude_deprecated branch from a9efb9e to 67cc870 Compare March 7, 2023 13:51
@perdasilva
fix vendor
b11dff0 
Signed-off-by: perdasilva <[email protected]>
@perdasilva
Copy link
Contributor Author

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

@perdasilva: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@emmajiafan
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 7, 2023
@perdasilva
Copy link
Contributor Author

/retest

rashmigottipati
rashmigottipati approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@rashmigottipati
Copy link
Member

/retest

everettraven
everettraven approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelryanpeter
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Mar 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anik120
Copy link
Contributor

anik120 commented Mar 7, 2023

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Mar 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2e352e7 into openshift:master Mar 7, 2023
@rashmigottipati
Copy link
Member

/cherrypick release-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 6, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rashmigottipati: new pull request created: #479

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@everettraven everettraven everettraven approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees

@rashmigottipati rashmigottipati

@everettraven everettraven

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@perdasilva @openshift-ci-robot @emmajiafan @rashmigottipati @michaelryanpeter @anik120 @openshift-cherrypick-robot @everettraven @openshift-merge-robot