Skip to content

OCPBUGS-11469: [release4.13] exclude bundles with olm.deprecated property when rendering #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #463

/assign rashmigottipati

rashmigottipati and others added 2 commits April 6, 2023 12:30
…ring (#1063)

* exclude bundles with `olm.deprecated` property when rendering

Signed-off-by: Rashmi Gottipati <[email protected]>

* Exclude bundles based on the property type and not value

Signed-off-by: Rashmi Gottipati <[email protected]>

---------

Signed-off-by: Rashmi Gottipati <[email protected]>
Upstream-repository: operator-registry
Upstream-commit: 0aeffa3f44f5e36bd2c0bcc63a94eda000a5f257
Signed-off-by: perdasilva <[email protected]>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023

@openshift-cherrypick-robot: [Jira Issue OPECO-2646](https://issues.redhat.com//browse/OPECO-2646) has been cloned as [Jira Issue OPECO-2779](https://issues.redhat.com//browse/OPECO-2779). Will retitle bug to link to clone.

WARNING: Failed to update the target version for the clone. Please update the target version manually. Full error below:

Full error message. customfield_12319940 - Version name '4.13.0' is not valid: request failed. Please analyze the request body for more details. Status code: 400:
/retitle [release-4.13] [OPECO-2779](https://issues.redhat.com//browse/OPECO-2779): exclude bundles with `olm.deprecated` property when rendering

In response to this:

This is an automated cherry-pick of #463

/assign rashmigottipati

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OPECO-2646: exclude bundles with olm.deprecated property when rendering [release-4.13] OPECO-2779: exclude bundles with olm.deprecated property when rendering Apr 6, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OPECO-2779: exclude bundles with olm.deprecated property when rendering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023

@openshift-cherrypick-robot: This pull request references OPECO-2779 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #463

/assign rashmigottipati

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from awgreene and joelanford April 6, 2023 12:30
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@grokspawn
Copy link
Contributor

/jira refresh

updated version fields in jira, seeing what automation will do with them.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023

@grokspawn: This pull request references OPECO-2779 which is a valid jira issue.

In response to this:

/jira refresh

updated version fields in jira, seeing what automation will do with them.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@adellape
Copy link
Contributor

adellape commented Apr 6, 2023

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Apr 6, 2023
@oceanc80
Copy link
Contributor

oceanc80 commented Apr 6, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 6, 2023
@rashmigottipati
Copy link
Member

/retest

@rashmigottipati
Copy link
Member

/test e2e-gcp-olm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@KeenonLee
Copy link
Member

/label qe-approved
/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2023

@KeenonLee: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label qe-approved
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 7, 2023
@jianzhangbjz
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 7, 2023
@oceanc80
Copy link
Contributor

oceanc80 commented Apr 7, 2023

/jira-refresh

@rashmigottipati
Copy link
Member

/retitle [release-4.13] OCPBUGS-11469: exclude bundles with olm.deprecated property when rendering

@openshift-ci openshift-ci bot changed the title [release-4.13] OPECO-2779: exclude bundles with olm.deprecated property when rendering [release-4.13] [OCPBUGS-11469](https://issues.redhat.com/browse/OCPBUGS-11469): exclude bundles with olm.deprecated property when rendering Apr 7, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 7, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #463

/assign rashmigottipati

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OCPBUGS-11469: exclude bundles with olm.deprecated property when rendering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oceanc80
Copy link
Contributor

oceanc80 commented Apr 7, 2023

/retitle OCPBUGS-11469: [release4.13] exclude bundles with olm.deprecated property when rendering

@openshift-ci openshift-ci bot changed the title [release-4.13] [OCPBUGS-11469](https://issues.redhat.com/browse/OCPBUGS-11469): exclude bundles with olm.deprecated property when rendering OCPBUGS-11469: [release4.13] exclude bundles with olm.deprecated property when rendering Apr 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-11469: [release4.13] exclude bundles with olm.deprecated property when rendering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 7, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-11469, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-11542 to target a version in 4.14.0, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #463

/assign rashmigottipati

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oceanc80
Copy link
Contributor

oceanc80 commented Apr 7, 2023

/jira-refresh

@rashmigottipati
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@rashmigottipati: This pull request references Jira Issue OCPBUGS-11469, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-11542 to target a version in 4.14.0, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rashmigottipati
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@rashmigottipati: This pull request references Jira Issue OCPBUGS-11469, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead
  • expected dependent Jira Issue OCPBUGS-11542 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Jira Issue OCPBUGS-11542 to target a version in 4.14.0, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rashmigottipati
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 7, 2023
@openshift-ci-robot
Copy link

@rashmigottipati: This pull request references Jira Issue OCPBUGS-11469, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-11542 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-11542 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @KeenonLee

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from KeenonLee April 7, 2023 16:20
@openshift-merge-robot openshift-merge-robot merged commit 3174a8a into openshift:release-4.13 Apr 7, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-11469: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11469 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #463

/assign rashmigottipati

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.