NO-ISSUE: [release-4.14] Backport e2e fixes to 4.14 #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
perdasilva
force-pushed
the
perdasilva/backport-e2e
branch
from
b54d96b to
807dac9
Compare
|
/lgtm |
perdasilva
force-pushed
the
perdasilva/backport-e2e
branch
from
8f56d6d to
5a081f0
Compare
|
New changes are detected. LGTM label has been removed. |
perdasilva
force-pushed
the
perdasilva/backport-e2e
branch
2 times, most recently
from
9cf34d1 to
f39517c
Compare
|
/retest |
1 similar comment
|
/retest |
perdasilva
force-pushed
the
perdasilva/backport-e2e
branch
from
f39517c to
c7d2b42
Compare
|
/retest |
The internal versions of the API Extensions client objects are what client calls get converted into for processing within the server. This mechanism allows many different clients to use many different outward-facing versions, while the code within the server only ever runs against one type. There is no utility to these types outside of the server, especially for code that's making client calls. We can simply use the client-facing types and not require coversion anywhere. Signed-off-by: Steve Kuznetsov <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 935fc47c13f21e505e1f52e82faeaccd70861425
Signed-off-by: Daniel Franz <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 6b6e3fbd724ddb6bfb1e31f75d3cac2a25cc5b86
Fix #3108 The Subscription needs to be deleted before deleting the CSV, otherwise the Subscription will recreate the CSV, and subsequently, the CR/CRBs are not deleted. Update some test logging as well. Signed-off-by: Todd Short <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 8215c7f3fe16b1135ddfc9de1d498fff2f75e659
perdasilva
force-pushed
the
perdasilva/backport-e2e
branch
from
c7d2b42 to
9a51030
Compare
Fix #3151 Remove non-InstallPlan related checks for this test. Also: * Clean up some looping log messages * Clean up some logging added when comments were converted These comments/logs are at the beginning of the test, and are also part of the test sequence, so they are redundant (and possibly confusing) Signed-off-by: Todd Short <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 5299830576c8e8e6cd728b08a3a2e60f212ba387
perdasilva
force-pushed
the
perdasilva/backport-e2e
branch
from
9a51030 to
e49a97c
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]> Co-authored-by: Per Goncalves da Silva <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 85d9de20d53b025ed62ec2fa0ab7fd8980669fb8
perdasilva
force-pushed
the
perdasilva/backport-e2e
branch
from
f5fc43b to
55e6a18
Compare
|
@perdasilva: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
perdasilva
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
perdasilva
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@perdasilva: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/backport-risk-assessed This PR contains no changes to product code, so this is a no-op for QE. Adding that label as well. |
kevinrizza
added
lgtm
openshift-ci
bot
assigned
bandrade,
emmajiafan,
jianzhangbjz,
KeenonLee,
kuiwang02 and
Xia-Zhao-rh
kevinrizza
added
the
jira/valid-bug
|
Forgot one! /label jira/valid-bug |
|
[ART PR BUILD NOTIFIER] This PR has been included in build operator-registry-container-v4.14.0-202402151739.p0.g84c3b96.assembly.stream.el8 for distgit operator-registry. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build operator-lifecycle-manager-container-v4.14.0-202402151739.p0.g84c3b96.assembly.stream.el8 for distgit operator-lifecycle-manager. |
|
/cherry-pick release-4.13 |
|
@perdasilva: #674 failed to apply on top of branch "release-4.13": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
perdasilva
pushed a commit
to perdasilva/operator-framework-olm
that referenced
this pull request
Sep 26, 2024
NO-ISSUE: [release-4.14] Backport e2e fixes to 4.14
perdasilva
pushed a commit
to perdasilva/operator-framework-olm
that referenced
this pull request
Sep 26, 2024
NO-ISSUE: [release-4.14] Backport e2e fixes to 4.14
|
/cherry-pick release-4.13 |
|
@perdasilva: #674 failed to apply on top of branch "release-4.13": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
perdasilva
pushed a commit
to perdasilva/operator-framework-olm
that referenced
this pull request
Oct 8, 2024
NO-ISSUE: [release-4.14] Backport e2e fixes to 4.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e-test backport based on #670 + another fix for a CRD flake test
This PR only changes e2e tests in an effort to make CI more reliable and reduce our time-to-merge.
This PR does not carry the bug fix from #670 - product changes are to be made by this PR.
Reviewers: please ensure all changes are under staging/operator-lifecycle-manager/test