Skip to content

NO-ISSUE: [release-4.13] Backport e2e fixes #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 30, 2024
Merged

NO-ISSUE: [release-4.13] Backport e2e fixes #876

merged 5 commits into from
Oct 30, 2024

Conversation

perdasilva
Copy link
Contributor

Backport of #674

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 26, 2024
@openshift-ci-robot
Copy link

@perdasilva: This pull request explicitly references no jira issue.

In response to this:

Backport of #674

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@perdasilva
Copy link
Contributor Author

/retest

@perdasilva
Copy link
Contributor Author

/retest e2e-gcp-olm-flaky

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

@perdasilva: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-gcp-console-olm
  • /test e2e-gcp-olm
  • /test e2e-gcp-ovn
  • /test e2e-upgrade
  • /test images
  • /test periodics-images
  • /test unit-api
  • /test unit-olm
  • /test unit-psm
  • /test unit-registry
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-gcp-olm-flaky

Use /test all to run all jobs.

In response to this:

/retest e2e-gcp-olm-flaky

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@perdasilva perdasilva force-pushed the perdasilva/backport/flake-fixes-4.13 branch from 08c2228 to 4f1e295 Compare October 8, 2024 07:39
stevekuznetsov and others added 2 commits October 8, 2024 16:27
@stevekuznetsov
test/e2e: don't use internal versions of api extensions
242c5f1 
The internal versions of the API Extensions client objects are what
client calls get converted into for processing within the server. This
mechanism allows many different clients to use many different
outward-facing versions, while the code within the server only ever runs
against one type. There is no utility to these types outside of the
server, especially for code that's making client calls. We can simply
use the client-facing types and not require coversion anywhere.

Signed-off-by: Steve Kuznetsov <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 935fc47c13f21e505e1f52e82faeaccd70861425
@dtfranz
Improve condition check for installplan (#3145)
ce50710 
Signed-off-by: Daniel Franz <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b6e3fbd724ddb6bfb1e31f75d3cac2a25cc5b86
@perdasilva perdasilva force-pushed the perdasilva/backport/flake-fixes-4.13 branch from 4f1e295 to 966a4f1 Compare October 8, 2024 14:33
@perdasilva
Copy link
Contributor Author

/retest

@perdasilva perdasilva force-pushed the perdasilva/backport/flake-fixes-4.13 branch from 966a4f1 to 9ccc37e Compare October 9, 2024 06:29
@perdasilva perdasilva changed the title NO-ISSUE: [release-4.13] Backport e2e fixes to 4.13 NO-ISSUE: [release-4.13] Backport e2e fixes Oct 10, 2024
@tmshort
Fix Create InstallPlan with Permissions test (#3129)
e5ed355 
Fix #3108
The Subscription needs to be deleted before deleting the CSV, otherwise
the Subscription will recreate the CSV, and subsequently, the CR/CRBs
are not deleted.

Update some test logging as well.

Signed-off-by: Todd Short <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 8215c7f3fe16b1135ddfc9de1d498fff2f75e659
@perdasilva perdasilva force-pushed the perdasilva/backport/flake-fixes-4.13 branch from 9ccc37e to 7a22ec4 Compare October 10, 2024 13:07
@perdasilva
Copy link
Contributor Author

/retest

1 similar comment
@perdasilva
Copy link
Contributor Author

/retest

@perdasilva perdasilva force-pushed the perdasilva/backport/flake-fixes-4.13 branch from 7a22ec4 to 2a625b8 Compare October 11, 2024 12:33
@perdasilva
Copy link
Contributor Author

/retest

1 similar comment
@perdasilva
Copy link
Contributor Author

/retest

tmshort and others added 2 commits October 15, 2024 08:42
@tmshort
Fix Condition check for Reconcile InstallPlan status (#3153)
657c138 
Fix #3151

Remove non-InstallPlan related checks for this test.

Also:
* Clean up some looping log messages
* Clean up some logging added when comments were converted

These comments/logs are at the beginning of the test, and are also part
of the test sequence, so they are redundant (and possibly confusing)

Signed-off-by: Todd Short <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 5299830576c8e8e6cd728b08a3a2e60f212ba387
@perdasilva
fix crd data loss e2e test (#3173)
d15a55d 
Signed-off-by: Per Goncalves da Silva <[email protected]>
Co-authored-by: Per Goncalves da Silva <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 85d9de20d53b025ed62ec2fa0ab7fd8980669fb8
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/backport/flake-fixes-4.13 branch from 2a625b8 to d15a55d Compare October 15, 2024 06:43
@perdasilva
Copy link
Contributor Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 15, 2024
@perdasilva
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tmshort
tmshort approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva
Copy link
Contributor Author

/label jira/valid-bug

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

@perdasilva: Can not set label jira/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

In response to this:

/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joelanford
Copy link
Member

Manually adding valid-bug label because these e2e fixes should reduce flakes and therefore time-to-merge

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 16, 2024
@perdasilva perdasilva mentioned this pull request Oct 17, 2024
Merged
@jianzhangbjz
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7f911e3 into openshift:release-4.13 Oct 30, 2024
13 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.13.0-202410300908.p0.g7f911e3.assembly.stream.el8.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.13.0-202410300908.p0.g7f911e3.assembly.stream.el8.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmshort tmshort tmshort approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@bandrade bandrade

@tmshort tmshort

@jianzhangbjz jianzhangbjz

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.