Bug 1927340: Add OperatorCondition status sync and update operator upgradeable check #92
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/assign timflannagan |
* Add conditions array to OperatorCondition's spec The conditions array in the spec is now available for operator to create/update as the operator progresses through installation process. As the spec is updated, the object generation will be incremented and it can be used for tracking object changes. Signed-off-by: Vu Dinh <[email protected]> * Add OperatorCondition v2 with spec.conditions array Upstream-commit: bb9b80e8278978efdb06a6f5d5682eb3cad330ec Upstream-repository: api Signed-off-by: Vu Dinh <[email protected]>
Upstream-commit: 083a907264ac07b75d33254b305b782470ae8835 Upstream-repository: api Signed-off-by: Vu Dinh <[email protected]>
Upstream-commit: 0dcbd99f9e5fea8a2ffbad6088437809a07d6d27 Upstream-repository: api Signed-off-by: Vu Dinh <[email protected]>
OperatorCondition controller will update its status to refect the changes on its spec regarding the operator conditions that are reported by the operators themselves. In turn, operators can read the status to confirm if OLM has processed the spec changes. OLM will not take actions on upgradeable condition if the status is stale using ObservedGeneration and Generation check. Upstream-commit: 4ae8df668dd098c204f757b8572fa608a9899bdc Upstream-repository: operator-lifecycle-manager Signed-off-by: Vu Dinh <[email protected]>
1. Operator can create/update/patch OperatorCondition but not its status. 2. Update the e2e test case to update OperatorCondition's spec directly instead of its status Upstream-commit: ff554972b5170a2757b4a09083503e7011bee382 Upstream-repository: operator-lifecycle-manager Signed-off-by: Vu Dinh <[email protected]>
1. Update codegen to generate operatorv2 client code 2. Vendor operator-framework/api 0.9.0 3. Adopt the new changes on OperatorCondition API from api repo. 4. Update OperatorCondition v2 references across the codebase 5. Update e2e test case for OperatorCondition Upstream-commit: f7d30f48f46d2fbe137d856d5a4bcf6b7d1420e2 Upstream-repository: operator-lifecycle-manager Signed-off-by: Vu Dinh <[email protected]>
Signed-off-by: Vu Dinh <[email protected]>
|
/lgtm |
dinhxuanvu
changed the title
openshift-ci
bot
added
the
bugzilla/severity-high
|
@dinhxuanvu: This pull request references Bugzilla bug 1927340, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@dinhxuanvu: All pull requests linked via external trackers have merged: Bugzilla bug 1927340 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OperatorCondition controller will update its status to refect the
changes on its spec regarding the operator conditions that are reported
by the operators themselves. In turn, operators can read the status
to confirm if OLM has processed the spec changes.
OLM will not take actions on upgradeable condition if the status is
stale using ObservedGeneration and Generation check.
Upstream-commit: 4ae8df668dd098c204f757b8572fa608a9899bdc
Upstream-repository: operator-lifecycle-manager
Signed-off-by: Vu Dinh [email protected]