Skip to content

BUG 1825349: Generation should not be a required field #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

awgreene
Copy link
Member

In the InstallPlan, the Generation field should not be required and may
be omitted.

Bugzilla Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1825349

In the InstallPlan, the Generation field should not be required and may
be omitted.

Bugzilla Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1825349
@openshift-ci-robot openshift-ci-robot added bugzilla/unspecified bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 20, 2020
@openshift-ci-robot
Copy link
Collaborator

@awgreene: This pull request references Bugzilla bug 1825349, which is invalid:

  • expected Bugzilla bug 1825349 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 1825349: Generation should not be a required field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@awgreene: This pull request references Bugzilla bug 1825349, which is invalid:

  • expected dependent Bugzilla bug 1825088 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 20, 2020
@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@awgreene awgreene force-pushed the generation-required-bug branch from c19a811 to b24a9dc Compare April 20, 2020 15:50
@awgreene
Copy link
Member Author

awgreene commented Apr 20, 2020

Pulled in a commit that @exdx created to improve e2e stability.

@awgreene
Copy link
Member Author

/retest

4 similar comments
@awgreene
Copy link
Member Author

/retest

@dangeoffroy
Copy link

/retest

@awgreene
Copy link
Member Author

/retest

@awgreene
Copy link
Member Author

/retest

@benluddy
Copy link
Contributor

benluddy commented Apr 21, 2020

/retest

{"command":"git fetch https://github.com/operator-framework/operator-lifecycle-manager.git --tags --prune","component":"clonerefs","error":"exit status 128","file":"prow/pod-utils/clone/clone.go:57","func":"k8s.io/test-infra/prow/pod-utils/clone.Run.func2","level":"info","msg":"Ran command","output":"fatal: unable to access 'https://github.com/operator-framework/operator-lifecycle-manager.git/': The requested URL returned error: 504\n","time":"2020-04-21T15:33:46Z"}

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/operator-framework_operator-lifecycle-manager/1467/pull-ci-operator-framework-operator-lifecycle-manager-release-4.4-images/38#1:build-log.txt%3A60

https://www.githubstatus.com/incidents/dsf2qtzh4jpz

@benluddy
Copy link
Contributor

/lgtm

@awgreene awgreene closed this Apr 21, 2020
@awgreene
Copy link
Member Author

Git outtage is preventing me from updating this PR. Closing in favor of #1473

@openshift-ci-robot
Copy link
Collaborator

@awgreene: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm e56e6c2 link /test e2e-aws-console-olm
ci/prow/unit e56e6c2 link /test unit
ci/prow/images e56e6c2 link /test images
ci/prow/verify e56e6c2 link /test verify
ci/prow/e2e-aws-olm e56e6c2 link /test e2e-aws-olm
ci/prow/e2e-gcp-upgrade e56e6c2 link /test e2e-gcp-upgrade
ci/prow/e2e-gcp e56e6c2 link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants