BUG 1825349: Generation required bug #1473

awgreene · 2020-04-21T16:48:59Z

In the InstallPlan, the Generation field should not be required and may
be omitted.

Bugzilla Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1825349

In the InstallPlan, the Generation field should not be required and may be omitted. Bugzilla Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1825349

openshift-ci-robot · 2020-04-21T16:50:52Z

@awgreene: This pull request references Bugzilla bug 1825349, which is invalid:

expected dependent Bugzilla bug 1825088 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 1825349: Generation required bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-21T16:52:12Z

@awgreene: This pull request references Bugzilla bug 1825349, which is invalid:

expected dependent Bugzilla bug 1825088 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 1825349: Generation required bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2020-04-21T16:52:18Z

/bugzilla refresh

openshift-ci-robot · 2020-04-21T16:52:34Z

@awgreene: This pull request references Bugzilla bug 1825349, which is invalid:

expected dependent Bugzilla bug 1825088 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 1825349: Generation required bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-21T16:54:33Z

@awgreene: This pull request references Bugzilla bug 1825349, which is invalid:

expected dependent Bugzilla bug 1825088 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2020-04-21T17:11:06Z

/retest

benluddy · 2020-04-21T17:19:50Z

/lgtm

awgreene · 2020-04-21T18:15:42Z

/retest

awgreene · 2020-04-21T18:35:53Z

/retest

awgreene · 2020-04-21T19:19:57Z

/test e2e-aws-olm

awgreene · 2020-04-21T19:26:55Z

/retest

ecordell · 2020-04-21T19:43:55Z

/approve

dinhxuanvu

/lgtm

openshift-ci-robot · 2020-04-21T19:45:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-04-21T19:48:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

awgreene · 2020-04-21T20:00:33Z

/test e2e-gcp

awgreene · 2020-04-21T21:13:29Z

/retest
TestDeleteInternalRegistryPodTriggersRecreation passes locally

awgreene · 2020-04-21T21:20:08Z

/test e2e-gcp

ERROR: (gcloud.compute.instance-groups.list-instances) could not parse resource []

awgreene · 2020-04-21T22:55:32Z

/test e2e-gcp
ERROR: (gcloud.compute.instance-groups.list-instances) could not parse resource []

openshift-bot · 2020-04-21T23:03:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-22T00:59:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-22T01:00:43Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-22T01:00:45Z

@openshift-bot: This pull request references Bugzilla bug 1825349, which is invalid:

expected dependent Bugzilla bug 1825088 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

russellb · 2020-04-22T01:52:36Z

/bugzilla refresh

openshift-ci-robot · 2020-04-22T01:52:39Z

@russellb: This pull request references Bugzilla bug 1825349, which is invalid:

expected dependent Bugzilla bug 1825088 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2020-04-22T03:35:15Z

/bugzilla refresh

openshift-ci-robot · 2020-04-22T03:35:19Z

@jianzhangbjz: This pull request references Bugzilla bug 1825349, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.0) matches configured target release for branch (4.4.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1825088 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1825088 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

russellb · 2020-04-22T13:26:33Z

@awgreene There are 3 commits in this PR, but only the first one seems related to the referenced bug. Can you add some more clarity on the other changes?

It would be really helpful to have a lot more detail in each commit message. For example, the other 2 commits only have a 1 line commit message and they don't do much to explain why the change was being made, so I'm having a hard time determining whether allowing those changes to be included is appropriate.

Thanks!

awgreene · 2020-04-22T14:16:54Z

Good question @russellb

@awgreene There are 3 commits in this PR, but only the first one seems related to the referenced bug. Can you add some more clarity on the other changes?

Sure - let's review the commits:

As you said, the first commit is the fix for the bug mentioned in the BZ.
The second commit updates an e2e test that would always fail because an image that the test relied on was updated.
The third updates an e2e test that was experiencing an extremely high failure rate - preventing bug fixes from getting into 4.4.

sdodson · 2020-04-22T14:17:55Z

/bugzilla refresh

openshift-ci-robot · 2020-04-22T14:17:59Z

@sdodson: This pull request references Bugzilla bug 1825349, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.0) matches configured target release for branch (4.4.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1825088 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1825088 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-22T14:41:22Z

@awgreene: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1473. Bugzilla bug 1825349 has been moved to the MODIFIED state.

In response to this:

BUG 1825349: Generation required bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene and others added 3 commits April 21, 2020 11:52

Generation should not be a required field

81b27ac

In the InstallPlan, the Generation field should not be required and may be omitted. Bugzilla Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1825349

fix: use busybox csv for polling e2e test

64ac634

fix: TestCreateNewSubscriptionWithPodConfig bug

e1fcb99

awgreene mentioned this pull request Apr 21, 2020

BUG 1825349: Generation should not be a required field #1467

Closed

awgreene changed the title ~~Generation required bug~~ BUG 1825349: Generation required bug Apr 21, 2020

openshift-ci-robot added the bugzilla/high label Apr 21, 2020

openshift-ci-robot requested review from benluddy and dinhxuanvu April 21, 2020 16:50

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 21, 2020

openshift-ci-robot assigned benluddy Apr 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2020

dinhxuanvu approved these changes Apr 21, 2020

View reviewed changes

openshift-ci-robot assigned dinhxuanvu Apr 21, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 22, 2020

shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 22, 2020

openshift-merge-robot merged commit a6acf50 into operator-framework:release-4.4 Apr 22, 2020

BUG 1825349: Generation required bug #1473

BUG 1825349: Generation required bug #1473

Uh oh!

Conversation

awgreene commented Apr 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 21, 2020

Uh oh!

openshift-ci-robot commented Apr 21, 2020

Uh oh!

awgreene commented Apr 21, 2020

Uh oh!

openshift-ci-robot commented Apr 21, 2020

Uh oh!

openshift-ci-robot commented Apr 21, 2020

Uh oh!

awgreene commented Apr 21, 2020

Uh oh!

benluddy commented Apr 21, 2020

Uh oh!

awgreene commented Apr 21, 2020

Uh oh!

awgreene commented Apr 21, 2020

Uh oh!

awgreene commented Apr 21, 2020

Uh oh!

awgreene commented Apr 21, 2020

Uh oh!

ecordell commented Apr 21, 2020

Uh oh!

dinhxuanvu left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 21, 2020

Uh oh!

openshift-bot commented Apr 21, 2020

Uh oh!

awgreene commented Apr 21, 2020

Uh oh!

awgreene commented Apr 21, 2020

Uh oh!

awgreene commented Apr 21, 2020

Uh oh!

awgreene commented Apr 21, 2020

Uh oh!

openshift-bot commented Apr 21, 2020

Uh oh!

openshift-bot commented Apr 22, 2020

Uh oh!

openshift-bot commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

russellb commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

jianzhangbjz commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

russellb commented Apr 22, 2020

Uh oh!

awgreene commented Apr 22, 2020

Uh oh!

sdodson commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

Uh oh!

awgreene commented Apr 21, 2020 •

edited

Loading