test(e2e): skip bundle cr install test #1640
Conversation
openshift-ci-robot
added
the
approved
Skip an e2e test that checks that newly introduced API types can be installed as part of a bundle. The test is failing consistently and should be reintegrated after commits fixing other test flakes -- that would be otherwise blocked by it -- are introduced and a root cause is identified.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/html |
| @@ -16,7 +16,7 @@ import ( | |||
| "github.com/operator-framework/operator-lifecycle-manager/test/e2e/ctx" | |||
| ) | |||
|
|
|||
| var _ = Describe("Installing bundles with new object types", func() { | |||
| var _ = PDescribe("Installing bundles with new object types", func() { | |||
There was a problem hiding this comment.
Trying to understand the difference b/w marking the spec as Pending vs Skip. The doc says:
_Using the P and X prefixes marks specs as pending at compile time. If you need to skip a spec at runtime (perhaps due to a constraint that can only be known at runtime) you may call Skip in your test
Shouldn't we be skipping the spec?
There was a problem hiding this comment.
P is for when you know at compile-time that you want to skip the test, Skip is for when you know at runtime.
|
/lgtm |
|
/test unit |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Skip an e2e test that checks that newly introduced API types can
be installed as part of a bundle. The test is failing consistently and
should be reintegrated after commits fixing other test flakes -- that
would be otherwise blocked by it -- are introduced and a root cause is
identified.
Currently, #1637 is most likely to reintegrate this test.