Skip to content

test(e2e): skip bundle cr install test #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2020
Merged

test(e2e): skip bundle cr install test #1640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/e2e/bundle_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import (
"github.com/operator-framework/operator-lifecycle-manager/test/e2e/ctx"
)

var _ = Describe("Installing bundles with new object types", func() {
// FIXME: Reintegrate this test
var _ = PDescribe("Installing bundles with new object types", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to understand the difference b/w marking the spec as Pending vs Skip. The doc says:

_Using the P and X prefixes marks specs as pending at compile time. If you need to skip a spec at runtime (perhaps due to a constraint that can only be known at runtime) you may call Skip in your test

Shouldn't we be skipping the spec?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P is for when you know at compile-time that you want to skip the test, Skip is for when you know at runtime.

var (
kubeClient operatorclient.ClientInterface
operatorClient versioned.Interface
Expand Down