Deprecated inner channel entries cause resolution error. #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
benluddy
force-pushed
the
deprecated-inner-entry-error
branch
from
386e61b to
c844035
Compare
Resolution would fail with an error in the presence of channels containing more than two entries with a deprecated inner entry (e.g. V1 -> V2 -> V3, with deprecated V2). This was due to special handling that filtered out deprecated bundles at the cache query layer. A channel's complete replaces-chain must be returned from cache queries in order to correctly determine the relative order between entries in the channel. Signed-off-by: Ben Luddy <[email protected]>
benluddy
force-pushed
the
deprecated-inner-entry-error
branch
from
c844035 to
5afaa1d
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
benluddy
changed the title
|
#2091 (x3) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2104, but this one happens because deprecated bundles are filtered out before they are returned from the catalog query layer:
operator-lifecycle-manager/pkg/controller/registry/resolver/cache.go
Line 404 in f40e8e5