[release-4.7] Bug 1969320: packageserver CSV: add missing properties #2192

vrutkovs · 2021-06-08T15:13:41Z

Description of the change:
packageserver CSV: add missing properties

Motivation for the change:
Some properties are unset and being set to defaults. CVO is however unware of it, so it attempts to remove the fields which are unset in the manifest files. This change would ensure CVO is not attempting to re-apply this manifest on every sync loop.

This is a cherry-pick of openshift/operator-framework-olm#84 on release-4.7 branch

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

openshift-ci · 2021-06-08T15:13:46Z

@vrutkovs: This pull request references Bugzilla bug 1969320, which is invalid:

expected dependent Bugzilla bug 1881522 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1969320: [release-4.7]packageserver CSV: add missing properties

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-08T15:13:49Z

Hi @vrutkovs. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

manifests/0000_50_olm_15-packageserver.clusterserviceversion.yaml

timflannagan · 2021-06-08T15:33:36Z

/ok-to-test

timflannagan · 2021-06-09T13:10:12Z

Looks like we're waiting on openshift/cluster-version-operator#561 to merge before the parent BZ can be verified.

Some properties are unset and being set to defaults. CVO is however unware of it, so it attempts to remove the fields which are unset in the manifest files. This PR should prevent CVO from hotlooping on this manifest Signed-off-by: Vadim Rutkovsky <[email protected]>

timflannagan · 2021-06-10T14:01:43Z

/bugzilla refresh
/retest

openshift-ci · 2021-06-10T14:01:56Z

@timflannagan: This pull request references Bugzilla bug 1969320, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1881522 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1881522 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan · 2021-06-10T14:02:20Z

/lgtm

benluddy · 2021-06-29T19:03:49Z

/approve

openshift-ci · 2021-06-29T19:03:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [benluddy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-07-01T00:20:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-01T01:08:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-06T23:13:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-07T02:40:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-07T03:06:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-07T03:19:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-07T04:11:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-07T04:37:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-07T04:50:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-07T05:42:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-07T05:55:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-07T06:08:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

vrutkovs · 2021-07-07T06:56:18Z

/hold

sdodson · 2021-07-15T15:08:37Z

/retest

timflannagan · 2021-08-04T15:51:59Z

Looks like the e2e-tests github action needs to be rebased - trying to close/re-open to see if it picks up newer branch content.

openshift-ci · 2021-08-04T15:52:06Z

@vrutkovs: An error was encountered adding this pull request to the external tracker bugs for bug 1969320 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


JSONRPC error 32000: Red Hat Bugzilla's database reported a query serialization error. Most likely this occurred because another user or process attempted to change the same data that you were attempting to change. Please press Back and retry the transaction.  UPDATE bugs SET delta_ts = ? WHERE bug_id = ? at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1516.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.7] Bug 1969320: packageserver CSV: add missing properties

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-04T15:52:08Z

@vrutkovs: This pull request references Bugzilla bug 1969320. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

[release-4.7] Bug 1969320: packageserver CSV: add missing properties

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kevinrizza · 2021-08-04T17:27:44Z

/hold cancel

tests are passing now

openshift-bot · 2021-08-04T19:10:22Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

ecordell · 2021-08-04T19:24:41Z

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

Score: 0.10
Reason: missed cutoff for today, may make tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

ecordell · 2021-08-05T18:56:02Z

[patch-manager] 🚀 Approved for z-stream by score: 0.10

picked

ecordell · 2021-08-05T22:41:46Z

/retest

vrutkovs · 2021-08-06T07:31:06Z

/retest

ecordell · 2021-08-06T15:13:22Z

/retest

upgrade test should be fixed

openshift-ci · 2021-08-06T17:13:04Z

@vrutkovs: All pull requests linked via external trackers have merged:

Bugzilla bug 1969320 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1969320: packageserver CSV: add missing properties

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2021

openshift-ci bot requested review from benluddy and joelanford June 8, 2021 15:13

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2021

vrutkovs mentioned this pull request Jun 8, 2021

Bug 1969320: [release-4.7] packageserver CSV: add missing properties openshift/operator-framework-olm#89

Closed

timflannagan reviewed Jun 8, 2021

View reviewed changes

manifests/0000_50_olm_15-packageserver.clusterserviceversion.yaml Show resolved Hide resolved

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2021

vrutkovs force-pushed the 4.7-cvo-hotlooping branch from 79f4d3e to c67f756 Compare June 9, 2021 12:59

timflannagan changed the title ~~Bug 1969320: [release-4.7]packageserver CSV: add missing properties~~ [release-4.7] Bug 1969320: packageserver CSV: add missing properties Jun 9, 2021

vrutkovs force-pushed the 4.7-cvo-hotlooping branch from c67f756 to f9304a2 Compare June 10, 2021 08:32

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 10, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 10, 2021

openshift-ci bot assigned timflannagan Jun 10, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021

bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 30, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021

timflannagan closed this Aug 4, 2021

timflannagan reopened this Aug 4, 2021

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021

ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 5, 2021

openshift-ci bot merged commit 4bfcded into operator-framework:release-4.7 Aug 6, 2021

vrutkovs mentioned this pull request Aug 17, 2021

[release-4.7] Bug 1969320: remove spec.cleanup from ClusterServiceVersion #2329

Merged

[release-4.7] Bug 1969320: packageserver CSV: add missing properties #2192

[release-4.7] Bug 1969320: packageserver CSV: add missing properties #2192

Uh oh!

Conversation

vrutkovs commented Jun 8, 2021

Uh oh!

openshift-ci bot commented Jun 8, 2021

Uh oh!

openshift-ci bot commented Jun 8, 2021

Uh oh!

Uh oh!

timflannagan commented Jun 8, 2021

Uh oh!

timflannagan commented Jun 9, 2021

Uh oh!

timflannagan commented Jun 10, 2021

Uh oh!

openshift-ci bot commented Jun 10, 2021

Uh oh!

timflannagan commented Jun 10, 2021

Uh oh!

benluddy commented Jun 29, 2021

Uh oh!

openshift-ci bot commented Jun 29, 2021

Uh oh!

openshift-bot commented Jul 1, 2021

Uh oh!

openshift-bot commented Jul 1, 2021

Uh oh!

openshift-bot commented Jul 6, 2021

Uh oh!

openshift-bot commented Jul 7, 2021

Uh oh!

openshift-bot commented Jul 7, 2021

Uh oh!

openshift-bot commented Jul 7, 2021

Uh oh!

openshift-bot commented Jul 7, 2021

Uh oh!

openshift-bot commented Jul 7, 2021

Uh oh!

openshift-bot commented Jul 7, 2021

Uh oh!

openshift-bot commented Jul 7, 2021

Uh oh!

openshift-bot commented Jul 7, 2021

Uh oh!

openshift-bot commented Jul 7, 2021

Uh oh!

vrutkovs commented Jul 7, 2021

Uh oh!

sdodson commented Jul 15, 2021

Uh oh!

timflannagan commented Aug 4, 2021

Uh oh!

openshift-ci bot commented Aug 4, 2021

Uh oh!

openshift-ci bot commented Aug 4, 2021

Uh oh!

kevinrizza commented Aug 4, 2021

Uh oh!

openshift-bot commented Aug 4, 2021

Uh oh!

ecordell commented Aug 4, 2021

Uh oh!

ecordell commented Aug 5, 2021

Uh oh!

ecordell commented Aug 5, 2021

Uh oh!

vrutkovs commented Aug 6, 2021

Uh oh!

ecordell commented Aug 6, 2021

Uh oh!

openshift-ci bot commented Aug 6, 2021

Uh oh!

Uh oh!