[release-4.7] Bug 1969320: remove spec.cleanup from ClusterServiceVersion

[vrutkovs]

spec.cleanup is not declared in CRD for 4.7, so it makes CVO hotloop

Followup for #2192, as https://bugzilla.redhat.com/show_bug.cgi?id=1969320 failed QE

[openshift-ci]

@vrutkovs: This pull request references Bugzilla bug 1969320, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1881522 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1881522 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
• bug has dependents

Requesting review from QA contact:
/cc @shellyyang1989

In response to this:

[release-4.7] Bug 1969320: remove spec.cleanup from ClusterServiceVersion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: shellyyang1989.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@vrutkovs: This pull request references Bugzilla bug 1969320, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1881522 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1881522 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
• bug has dependents

Requesting review from QA contact:
/cc @shellyyang1989

In response to this:

[release-4.7] Bug 1969320: remove spec.cleanup from ClusterServiceVersion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Hi @vrutkovs. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vrutkovs]

/cc @timflannagan

[timflannagan]

/ok-to-test

[timflannagan]

/lgtm

[timflannagan]

@kevinrizza Are we okay with directly modifying the root list of manifests here?

[shellyyang1989]

/lgtm

[openshift-ci]

@shellyyang1989: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shellyyang1989]

/label qe-approved

[shellyyang1989]

/bugzilla cc-qa
Steps to verify it:

1. Build a payload with this PR using cluster-bot

2. Install a cluster with the payload built in step 1.

3. Check the audit log

$ oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.7.0-0.ci.test-2021-08-18-061332-ci-ln-6jdrj8k-latest True False 18m Cluster version is 4.7.0-0.ci.test-2021-08-18-061332-ci-ln-6jdrj8k-latest

$ masters=$(oc get no -l node-role.kubernetes.io/master | sed '1d' | awk '{print $1}')

$ oc adm node-logs $masters --path=kube-apiserver/audit.log --raw | zgrep -h '"verb":"update"."resource":"."packageserver"' 2>/dev/null | jq -r '.user.username + " " + (.objectRef | .resource + " " + .namespace + " " + .name + " " + .apiGroup) + " " + .stageTimestamp + " " + (.responseStatus | tostring)' | sort
null

4. Check CVO log

$ grep "Updating ClusterServiceVersion openshift-operator-lifecycle-manager/packageserver" /tmp/cvo1.log
null

CVO no longer hotloops on packageserver.

[openshift-ci]

@shellyyang1989: This pull request references Bugzilla bug 1969320, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1881522 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1881522 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
• bug has dependents

Requesting review from QA contact:
/cc @shellyyang1989

In response to this:

/bugzilla cc-qa
Steps to verify it:

1. Build a payload with [release-4.7] Bug 1969320: remove spec.cleanup from ClusterServiceVersion #2329 using cluster-bot

build #2329

2. Install a cluster with the payload built in step 1.

3. Check the audit log

oc get clusterversion

NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.7.0-0.ci.test-2021-08-18-061332-ci-ln-6jdrj8k-latest True False 18m Cluster version is 4.7.0-0.ci.test-2021-08-18-061332-ci-ln-6jdrj8k-latest

masters=$(oc get no -l node-role.kubernetes.io/master | sed '1d' | awk '{print $1}')

oc adm node-logs $masters --path=kube-apiserver/audit.log --raw | zgrep -h '"verb":"update"."resource":"."packageserver"' 2>/dev/null | jq -r '.user.username + " " + (.objectRef | .resource + " " + .namespace + " " + .name + " " + .apiGroup) + " " + .stageTimestamp + " " + (.responseStatus | tostring)' | sort

null

4. Check CVO log

grep "Updating ClusterServiceVersion openshift-operator-lifecycle-manager/packageserver" /tmp/cvo1.log

null

CVO no longer hotloops on packageserver.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: shellyyang1989.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@shellyyang1989: This pull request references Bugzilla bug 1969320, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1881522 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1881522 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
• bug has dependents

Requesting review from QA contact:
/cc @shellyyang1989

In response to this:

/bugzilla cc-qa
Steps to verify it:

1. Build a payload with [release-4.7] Bug 1969320: remove spec.cleanup from ClusterServiceVersion #2329 using cluster-bot

build #2329

2. Install a cluster with the payload built in step 1.

3. Check the audit log

oc get clusterversion

NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.7.0-0.ci.test-2021-08-18-061332-ci-ln-6jdrj8k-latest True False 18m Cluster version is 4.7.0-0.ci.test-2021-08-18-061332-ci-ln-6jdrj8k-latest

masters=$(oc get no -l node-role.kubernetes.io/master | sed '1d' | awk '{print $1}')

oc adm node-logs $masters --path=kube-apiserver/audit.log --raw | zgrep -h '"verb":"update"."resource":"."packageserver"' 2>/dev/null | jq -r '.user.username + " " + (.objectRef | .resource + " " + .namespace + " " + .name + " " + .apiGroup) + " " + .stageTimestamp + " " + (.responseStatus | tostring)' | sort

null

4. Check CVO log

grep "Updating ClusterServiceVersion openshift-operator-lifecycle-manager/packageserver" /tmp/cvo1.log

null

CVO no longer hotloops on packageserver.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timflannagan]

/retest

[kevinrizza]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[mfojtik]

[patch-manager] 🚀 Approved for z-stream by score: 0.10

adding cherry-pick approved

[timflannagan]

(manually adding the cherry-pick-approved label as michal doesn't have the requisite permissions in this organization)

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[timflannagan]

Blocked until #2351 can be merged.

[timflannagan]

/retest

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@vrutkovs: All pull requests linked via external trackers have merged:

• operator-framework/operator-lifecycle-manager#2329

Bugzilla bug 1969320 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1969320: remove spec.cleanup from ClusterServiceVersion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.