Skip to content

[release-4.7] Fix kubebuilder installation in the build root Dockerfile #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Member

Update the base.Dockerfile and fix the kubebuilder installation. That
vanity URL is no longer correctly serving the v2.3.1 release tar.gz
file. Update to instead curl directly from the github releases URL.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2021

@timflannagan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix kubebuilder installation in the build root Dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timflannagan
To complete the pull request process, please assign benluddy after the PR has been reviewed.
You can assign the PR to them by writing /assign @benluddy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from benluddy and exdx September 9, 2021 13:39
Update the base.Dockerfile and fix the kubebuilder installation. That
vanity URL is no longer correctly serving the v2.3.1 release tar.gz
file. Update to instead curl directly from the github releases URL.

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan force-pushed the fix-build-root-dockerfile branch from ff230c8 to 883d45b Compare September 9, 2021 13:40
@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2021

@timflannagan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 883d45b link /test e2e-aws-console-olm
ci/prow/images 883d45b link /test images
ci/prow/unit 883d45b link /test unit
ci/prow/verify 883d45b link /test verify
ci/prow/e2e-aws-olm 883d45b link /test e2e-aws-olm
ci/prow/e2e-gcp 883d45b link /test e2e-gcp
ci/prow/e2e-upgrade 883d45b link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@timflannagan timflannagan changed the title Fix kubebuilder installation in the build root Dockerfile [release-4.7] Fix kubebuilder installation in the build root Dockerfile Sep 9, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2021

@timflannagan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.7] Fix kubebuilder installation in the build root Dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kevinrizza
Copy link
Member

force merging due to permafailing ci

@timflannagan timflannagan deleted the fix-build-root-dockerfile branch September 9, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants