Skip to content

.github/workflows: Don't run CI checks for markdown-only updates #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Member

Update the ci-prefixed workflows and ensure that CI isn't running when
only markdown files are updated.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@timflannagan timflannagan force-pushed the fix-ci-doesnt-run-on-readme-updates branch 2 times, most recently from 4bd4e2f to 5d0d075 Compare September 8, 2021 19:12
Update the ci-prefixed workflows and ensure that CI isn't running when
only markdown files are updated.

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan force-pushed the fix-ci-doesnt-run-on-readme-updates branch from 5d0d075 to 1cdfb7c Compare September 8, 2021 19:13
@timflannagan timflannagan force-pushed the fix-ci-doesnt-run-on-readme-updates branch from 3e5e51a to c2b5303 Compare September 8, 2021 19:19
@timflannagan timflannagan force-pushed the fix-ci-doesnt-run-on-readme-updates branch 2 times, most recently from 3a13f0d to 6de54ba Compare September 8, 2021 19:38
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
The '**/*.md' filter pattern [1] should ignore _all_ markdown extension
files anywhere in the repository.

[1] https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#patterns-to-match-file-paths

Signed-off-by: timflannagan <[email protected]>
@timflannagan timflannagan force-pushed the fix-ci-doesnt-run-on-readme-updates branch from 6de54ba to 12df9df Compare September 8, 2021 19:40
@timflannagan
Copy link
Member Author

#2091

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, njhale, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2fd0140 into operator-framework:master Sep 8, 2021
@timflannagan timflannagan deleted the fix-ci-doesnt-run-on-readme-updates branch September 8, 2021 23:55
timflannagan added a commit to timflannagan/operator-lifecycle-manager that referenced this pull request Sep 15, 2021
Update the sanity workflow and avoid running the defined jobs when only
markdown changes are present in the PR. This is a follow-up to operator-framework#2347
which enabled this behavior with the other actions, and this sanity
action was introduced after that PR had already merged.

Signed-off-by: timflannagan <[email protected]>
openshift-merge-robot pushed a commit that referenced this pull request Sep 16, 2021
#2356)

Update the sanity workflow and avoid running the defined jobs when only
markdown changes are present in the PR. This is a follow-up to #2347
which enabled this behavior with the other actions, and this sanity
action was introduced after that PR had already merged.

Signed-off-by: timflannagan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants