Skip to content

.github/workflows: Don't run the sanity jobs for markdown-only updates #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Member

Description of the change:
Update the sanity workflow and avoid running the defined jobs when only
markdown changes are present in the PR. This is a follow-up to #2347
which enabled this behavior with the other actions, and this sanity
action was introduced after that PR had already merged.

Motivation for the change:
No need to run CI checks on markdown-only changes.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

Update the sanity workflow and avoid running the defined jobs when only
markdown changes are present in the PR. This is a follow-up to operator-framework#2347
which enabled this behavior with the other actions, and this sanity
action was introduced after that PR had already merged.

Signed-off-by: timflannagan <[email protected]>
@estroz
Copy link
Member

estroz commented Sep 15, 2021

/lgtm
/rerun-all

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dinhxuanvu
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@openshift-merge-robot openshift-merge-robot merged commit 26c36d7 into operator-framework:master Sep 16, 2021
@timflannagan timflannagan deleted the update-sanity-workflow branch September 16, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants