Replace hardcoded resolver cache mutation with CSV cache.Source. #2632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
benluddy
force-pushed
the
csv-source
branch
3 times, most recently
from
4588760 to
1603d7d
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Signed-off-by: Ben Luddy <[email protected]>
|
/lgtm |
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolver depends on getting a cache of snapshots of all available catalogs, then synthesizing an extra snapshot containing the CSVs in the target namespace and inserting it into the cache. The
cache.Sourceandcache.SourceProviderinterfaces were introduced to support injecting cache entries from various non-registry sources. Implementing these interfaces reduces the coupling between the core resolution component and the CSV API, which should be a benefit if/when it comes time to support new on-cluster dependency resolution APIs. As an added benefit, the exported surface of the cache package shrinks.