Give Sources control of invalidation for Snapshots they produce. #2651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
benluddy
force-pushed
the
source-controlled-invalidation
branch
from
3744d03 to
b8fc028
Compare
This moves the hard-coded 5-minute TTL out of the cache and into the registry-based implementation of cache.Source. The hack that makes snapshots produced by "virtual" sources is no longer necessary. Signed-off-by: Ben Luddy <[email protected]>
benluddy
force-pushed
the
source-controlled-invalidation
branch
from
b8fc028 to
1107c80
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the hard-coded 5-minute TTL out of the cache and into the
registry-based implementation of cache.Source. The hack that makes
snapshots produced by "virtual" sources is no longer necessary.
/hold
Depends on #2632 now, but could be rebased onto master without much trouble if the other PR gets stuck.