Skip to content

Allow some commands to generate k8s, without requiring build files. #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2019
Merged

Allow some commands to generate k8s, without requiring build files. #1966

merged 5 commits into from
Oct 10, 2019

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Sep 25, 2019 •
edited
Loading

Description of the change:

  • Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one.
  • Not relay in the Dockerfile in order to support other kinds of containers.

Motivation for the change:

Closes: #1804 and #1686

PS.: Helpful for #1964

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2019
@camilamacedo86 camilamacedo86 changed the title WIP: subcommands should only require pkg/apis exist, not full project Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one. Sep 26, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2019
@camilamacedo86 camilamacedo86 changed the title Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one. WIP : Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one. Sep 26, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2019
@camilamacedo86 camilamacedo86 changed the title WIP : Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one. Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one. Sep 26, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2019
@camilamacedo86 camilamacedo86 mentioned this pull request Sep 26, 2019
Closed
@estroz

This comment has been minimized.

Sign in to view
@camilamacedo86 camilamacedo86 changed the title Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one. WIP: Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one. Sep 26, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 26, 2019
@camilamacedo86 camilamacedo86 changed the title WIP: Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one. Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one. Sep 28, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2019
@camilamacedo86

This comment has been minimized.

Sign in to view
@camilamacedo86 camilamacedo86 requested a review from asmacdo October 8, 2019 22:34
jmccormick2001
jmccormick2001 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@jmccormick2001 jmccormick2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building it locally it seems to work in my test of it.

jmrodri
jmrodri requested changes Oct 9, 2019
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I think we should change.

@jmrodri
Copy link
Member

jmrodri commented Oct 9, 2019

Why is there 2 merge commits in this PR? That's weird to me. Can you rebase and clean those up?

@jmrodri
Copy link
Member

jmrodri commented Oct 9, 2019

Also the PR title and the first commit are really long.

Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one.

I try to keep the first line of the commit message as a subject line in an email. Then to clarify I add one blank line then add as much text as I want to subsequent lines to describe in more detail what I did in the commit.

I would suggest something more like this:

Allow some commands to generate k8s, without requiring build files.

This commit allows some commands to generate k8s and openapi files without requiring the presence of build files like Dockerfile, main.go, etc.

@jmrodri jmrodri changed the title Be able to execute the commands operator-sdk generate k8s and openapi without relay in the existence of the Dockerfile and/or main.go one. Allow some commands to generate k8s, without requiring build files. Oct 9, 2019
@camilamacedo86 camilamacedo86 requested a review from jmrodri October 9, 2019 19:33
jmrodri
jmrodri reviewed Oct 9, 2019
View reviewed changes
camilamacedo86
camilamacedo86 commented Oct 9, 2019
View reviewed changes
@camilamacedo86 camilamacedo86 requested a review from jmrodri October 9, 2019 22:01
@camilamacedo86
Copy link
Contributor Author

/test e2e-aws-ansible

1 similar comment
@camilamacedo86
Copy link
Contributor Author

/test e2e-aws-ansible

@jmrodri jmrodri merged commit a3458ab into operator-framework:master Oct 10, 2019
@camilamacedo86 camilamacedo86 deleted the ISSUE_1804 branch October 10, 2019 15:38
joelanford added a commit to joelanford/operator-sdk that referenced this pull request Oct 10, 2019
@joelanford
Revert "Allow some commands to generate k8s, without requiring build …
854f0ba 
…files. (operator-framework#1966)"

This reverts commit a3458ab.
@joelanford joelanford mentioned this pull request Oct 10, 2019
Merged
hasbro17 pushed a commit that referenced this pull request Oct 10, 2019
@joelanford @hasbro17
Revert "Allow some commands to generate k8s, without requiring build …
3448eaf 
…files. (#1966)" (#2039)

This reverts commit a3458ab.
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 12, 2019
Closed
fabianvf pushed a commit to fabianvf/operator-sdk that referenced this pull request Oct 14, 2019
@camilamacedo86 @fabianvf
Allow some commands to generate k8s, without requiring build files. (o…
f8ebed4 
…perator-framework#1966)

* Allow some commands to generate k8s, without requiring build files.
* update changelog
* adpt sub-commands
* review changes
* Update cmd/operator-sdk/main.go
fabianvf pushed a commit to fabianvf/operator-sdk that referenced this pull request Oct 14, 2019
@joelanford @fabianvf
Revert "Allow some commands to generate k8s, without requiring build …
6be44a4 
…files. (operator-framework#1966)" (operator-framework#2039)

This reverts commit a3458ab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmccormick2001 jmccormick2001 jmccormick2001 approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@joelanford joelanford Awaiting requested review from joelanford

@estroz estroz Awaiting requested review from estroz

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@asmacdo asmacdo Awaiting requested review from asmacdo

@fabianvf fabianvf Awaiting requested review from fabianvf

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate: subcommands should only require pkg/apis exist, not full project
5 participants
@camilamacedo86 @estroz @jmrodri @jmccormick2001 @openshift-ci-robot