Skip to content

Revert "Allow some commands to generate k8s, without requiring build … #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

joelanford
Copy link
Member

…files. (#1966)"

Description of the change:
This reverts #1966 (commit a3458ab).

Motivation for the change:
We need to improve the CHANGELOG wording, error messages, and make sure there are no unintended side effects of these changes before including them in a release.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2019
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmrodri
Copy link
Member

jmrodri commented Oct 10, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2019
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@hasbro17
Copy link
Contributor

/test e2e-aws-ansible

1 similar comment
@hasbro17
Copy link
Contributor

/test e2e-aws-ansible

@hasbro17 hasbro17 mentioned this pull request Oct 10, 2019
@hasbro17 hasbro17 merged commit 3448eaf into operator-framework:master Oct 10, 2019
@joelanford joelanford deleted the revert-1966 branch October 11, 2019 15:49
fabianvf pushed a commit to fabianvf/operator-sdk that referenced this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants