Skip to content

Revert "decompose GOPATH and set it according to the current working dir." #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2018
Merged

Revert "decompose GOPATH and set it according to the current working dir." #721

merged 2 commits into from
Nov 8, 2018

Conversation

shawn-hurley
Copy link
Member

Reverts #712

@shawn-hurley shawn-hurley requested a review from estroz November 8, 2018 19:31
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2018
@AlexNPavel
Copy link
Contributor

Why is the sed commit getting reverted? That's just documentation and shouldn' break anything

@shawn-hurley
Copy link
Member Author

shawn-hurley commented Nov 8, 2018 •
edited
Loading

@AlexNPavel it's not, this is reverting #712 not #699

AlexNPavel
AlexNPavel approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@AlexNPavel AlexNPavel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I got confused because there were 2 commits (one of them being sed). The one mentioning sed is actually empty, so I guess it's just Github being weird.
LGTM

@shawn-hurley shawn-hurley merged commit b3885b9 into master Nov 8, 2018
@estroz estroz mentioned this pull request Nov 8, 2018
Merged
@estroz estroz deleted the revert-712-decompose_gopath branch November 21, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexNPavel AlexNPavel AlexNPavel approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@estroz estroz estroz approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shawn-hurley @AlexNPavel @hasbro17 @estroz @openshift-ci-robot