generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 43
Merge telemetry into main with conflicts resolved #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded dev dependencies and removed unused dependencies
Merging main into telemetry
some bug fixes and added debug logger Added flag to disable telemetry feature Updated LspServerTelemetryManager with slight refinements 1. The workspaceInfo values, especially the javaVersion field. 2. Also reverted the sendTelemetry() methods to the state similar to earlier definitions with synchronized blocks; with minor refactoring improvements. 3. Added the missed changes in NbCodeClientCapabilities for the addition of the wantsTelemetryEnabled field. Signed-off-by: Siddharth Srinivasan <[email protected]> Updated telemetry l10n with only english 1. Added the same english key value for telemetry setting and message in all language bundles. This is to ensure that tests pass. 2. Removed the unused dependency "axios" pruned further dependencies of it. 3. Updated minimum runtime JDK version to 23 instead of 22 in l10n messages. Signed-off-by: Siddharth Srinivasan <[email protected]>
Initial structure of telemetry feature in the extension
2) Added build time config for telemetry 3) Fixed status code around bug 4) added important headers in the post request of telemetry events
Merge 'main' into 'telemetry'
Improvements in telemetry client
…trigger ensure workspaceChangeEvent interval is triggered only once
Updated telemetry event triggers
1. Amended LspServerTelemetryManager to expose isPreviewEnabled() method and associated enums and methods to populate JdkFeatureEvent. 2. Amended NbCodeClientCapabilites.wantsTelemetryEnabled() to avoid an NPE in case of null Boolean -> boolean conversion. 3. Fixed handlers.ts to receive jdkFeature event from LSP and send it to the telemetry reporter. 4. Fixed jdkFeatures.ts to properly coalesce multiple events. Signed-off-by: Siddharth Srinivasan <[email protected]>
…ure-event Fixes and edits to telemetry code to support JdkFeatureEvent
workspace root are recognized 1. Amended LspServerTelemetryManager.sendWorkspaceInfo to use a NavigableMap to find sub-paths of the workspaceFolder that correspond to Projects, when it is not itself a Project. 2. Also, caught exceptions from ProjectProblems.isBroken() since it maybe a sign of a broken project. Signed-off-by: Siddharth Srinivasan <[email protected]>
features from the NetBeans LSP Server. 1. Added nbcode.java.lsp.server.telemetry module to provide the implementation. 2. Added jdk.compiler module access to NBLS in launchOptions.ts Co-authored-by: Jan Lahoda @lahodaj Co-authored-by: Siddharth Srinivasan @sid-srini Signed-off-by: Siddharth Srinivasan <[email protected]>
…projects-workspace-info Fixes to TelemetryServerManager to ensure multi-module projects under a workspace root are recognized
Adding initial structure of telemetry jdkFeatures event generation
Brings changes up-to-date from 23.1.0 GA.
Merge main branch into feature branch
Fixed label and id issue in JDK downloader
Fixed ids coming up as label issue in JDK Downloader
Merging the latest changes from 'main', corresponding to v. 24.0.0 with merge conflicts resolved.
Merge main into telemetry
Added 429 error code retryable support
union across the source root instead of only those in the active editor. Signed-off-by: Siddharth Srinivasan <[email protected]>
Enhancement in telemetry preferences flow and some telemetry maintenance changes
…che-update Updated telemetry jdk-features cache expiry time and maintenance as a
1. Added a detailed data usage policy document as vscode/TELEMETRY.md 2. Updated telemetry consent settings and pop-up messages to refer to this document. Signed-off-by: Siddharth Srinivasan <[email protected]>
…-messages Updating telemetry consent messages
sid-srini
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged main into telemetry to resolve all the merge conflicts.