remove deprecated downcast argument
#1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
remove-deprecated-downcast
branch
from
7b1fde3 to
8e37f80
Compare
MarcoGorelli
commented
Feb 20, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return valueI was going to tighten the annotations on
downcast, but then noticed that it's deprecated across all of these functionsAs far as I understand, the pandas-stubs policy is to remove deprecated arguments, to nudge people towards away from deprecated calls
The
deprecateddecorator has been brought up, but as far as I can tell that only applies to deprecated functions, rather than to single arguments https://peps.python.org/pep-0702/