Skip to content

remove deprecated downcast argument #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025
Merged

remove deprecated downcast argument #1127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e37f80
remove deprecated `downcast` argument
MarcoGorelli Feb 20, 2025
6c8d3b8
in fact, we can remove fillna from generic, right?
MarcoGorelli Feb 20, 2025
d2a9f78
remove downcast from index.fillna, remove multiindex.fillna
MarcoGorelli Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions pandas-stubs/core/frame.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
*,
axis: Axis | None = ...,
limit: int = ...,
downcast: dict | None = ...,
inplace: Literal[True],
) -> None: ...
@overload
Expand All @@ -795,7 +794,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
*,
axis: Axis | None = ...,
limit: int = ...,
downcast: dict | None = ...,
inplace: Literal[False] = ...,
) -> Self: ...
@overload
Expand Down Expand Up @@ -1719,7 +1717,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
inplace: Literal[True],
limit: int | None = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: dict | None = ...,
) -> None: ...
@overload
def bfill(
Expand All @@ -1729,7 +1726,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
inplace: Literal[False] = ...,
limit: int | None = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: dict | None = ...,
) -> Self: ...
@overload
def clip(
Expand Down Expand Up @@ -1812,7 +1808,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
inplace: Literal[True],
limit: int | None = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: dict | None = ...,
) -> None: ...
@overload
def ffill(
Expand All @@ -1822,7 +1817,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
inplace: Literal[False] = ...,
limit: int | None = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: dict | None = ...,
) -> Self: ...
def filter(
self,
Expand Down Expand Up @@ -1864,7 +1858,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
limit: int | None = ...,
limit_direction: Literal["forward", "backward", "both"] = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: Literal["infer"] | None = ...,
inplace: Literal[True],
**kwargs,
) -> None: ...
Expand All @@ -1877,7 +1870,6 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
limit: int | None = ...,
limit_direction: Literal["forward", "backward", "both"] = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: Literal["infer"] | None = ...,
inplace: Literal[False] = ...,
**kwargs,
) -> Self: ...
Expand Down
20 changes: 0 additions & 20 deletions pandas-stubs/core/generic.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,26 +437,6 @@ class NDFrame(indexing.IndexingMixin):
dtype_backend: DtypeBackend = ...,
) -> Self: ...
@overload
def fillna(
self,
value=...,
*,
axis=...,
inplace: Literal[True],
limit=...,
downcast=...,
) -> None: ...
@overload
def fillna(
self,
value=...,
*,
axis=...,
inplace: Literal[False] = ...,
limit=...,
downcast=...,
) -> NDFrame: ...
@overload
def replace(
self,
to_replace=...,
Expand Down
2 changes: 1 addition & 1 deletion pandas-stubs/core/indexes/base.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ class Index(IndexOpsMixin[S1]):
isnull = ...
def notna(self): ...
notnull = ...
def fillna(self, value=..., downcast=...): ...
def fillna(self, value=...): ...
def dropna(self, how: Literal["any", "all"] = ...) -> Self: ...
def unique(self, level=...) -> Self: ...
def drop_duplicates(self, *, keep: NaPosition | Literal[False] = ...) -> Self: ...
Expand Down
2 changes: 1 addition & 1 deletion pandas-stubs/core/indexes/category.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class CategoricalIndex(ExtensionIndex[S1], accessor.PandasDelegate):
def __contains__(self, key) -> bool: ...
def __array__(self, dtype=...) -> np.ndarray: ...
def astype(self, dtype: DtypeArg, copy: bool = ...) -> Index: ...
def fillna(self, value=..., downcast=...): ...
def fillna(self, value=...): ...
@property
def is_unique(self) -> bool: ...
@property
Expand Down
1 change: 0 additions & 1 deletion pandas-stubs/core/indexes/multi.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ class MultiIndex(Index[Any]):
@property
def is_monotonic_decreasing(self) -> bool: ...
def duplicated(self, keep: Literal["first", "last", False] = ...): ...
def fillna(self, value=..., downcast=...) -> None: ...
def dropna(self, how: Literal["any", "all"] = ...) -> Self: ...
def get_level_values(self, level: str | int) -> Index: ...
def unique(self, level=...): ...
Expand Down
3 changes: 0 additions & 3 deletions pandas-stubs/core/resample.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ from typing_extensions import (
TypeAlias,
)

from pandas._libs.lib import NoDefault
from pandas._typing import (
S1,
Axis,
Expand Down Expand Up @@ -105,7 +104,6 @@ class Resampler(BaseGroupBy[NDFrameT]):
inplace: Literal[True],
limit_direction: Literal["forward", "backward", "both"] = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: Literal["infer"] | None | NoDefault = ...,
**kwargs,
) -> None: ...
@overload
Expand All @@ -118,7 +116,6 @@ class Resampler(BaseGroupBy[NDFrameT]):
inplace: Literal[False] = ...,
limit_direction: Literal["forward", "backward", "both"] = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: Literal["infer"] | None | NoDefault = ...,
**kwargs,
) -> NDFrameT: ...
def asfreq(self, fill_value: Scalar | None = ...) -> NDFrameT: ...
Expand Down
8 changes: 0 additions & 8 deletions pandas-stubs/core/series.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
*,
axis: AxisIndex = ...,
limit: int | None = ...,
downcast: dict | None = ...,
inplace: Literal[True],
) -> None: ...
@overload
Expand All @@ -1085,7 +1084,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
*,
axis: AxisIndex = ...,
limit: int | None = ...,
downcast: dict | None = ...,
inplace: Literal[False] = ...,
) -> Series[S1]: ...
@overload
Expand Down Expand Up @@ -1302,7 +1300,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
inplace: Literal[True],
limit: int | None = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: dict | None = ...,
) -> None: ...
@overload
def ffill(
Expand All @@ -1312,7 +1309,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
inplace: Literal[False] = ...,
limit: int | None = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: dict | None = ...,
) -> Series[S1]: ...
@overload
def bfill(
Expand All @@ -1322,7 +1318,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
inplace: Literal[True],
limit: int | None = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: dict | None = ...,
) -> None: ...
@overload
def bfill(
Expand All @@ -1332,7 +1327,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
inplace: Literal[False] = ...,
limit: int | None = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: dict | None = ...,
) -> Series[S1]: ...
@overload
def interpolate(
Expand All @@ -1344,7 +1338,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
inplace: Literal[True],
limit_direction: Literal["forward", "backward", "both"] | None = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: Literal["infer"] | None = ...,
**kwargs,
) -> None: ...
@overload
Expand All @@ -1357,7 +1350,6 @@ class Series(IndexOpsMixin[S1], NDFrame):
inplace: Literal[False] = ...,
limit_direction: Literal["forward", "backward", "both"] | None = ...,
limit_area: Literal["inside", "outside"] | None = ...,
downcast: Literal["infer"] | None = ...,
**kwargs,
) -> Series[S1]: ...
def asof(
Expand Down