BUG: reindex with empty inputs

[ajspera]

…seless in that case anyway

• closes some argument combinations with reindex fails on an empty dataframe #27315
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[jreback]

pls always add tests

[jreback]

find the reindex tests; we need to run all combinations of args for an empty

[ajspera]

Will do when I find some more time this week... New to the python world and this project so I need a few more moments to get familiar with the testing.

[ajspera]

@jreback, could the tests be a while loop on a dict list using **kwargs on the method or are you looking for explicit individual tests for each arg combination? The former makes sense to me for efficiency, but being relatively new to python projects I'm not sure whether that overly obfuscates failure messages. Also I noticed the entry point on reindex tests are not on the class where I discovered the issue or even in the stack trace of those errors, and the class that I changed is further down inheritance of the tested class in there. Should we write tests for higher level DataFrame.reindex or should we go for the lowest public granularity of where (assuming private methods are not test targets like other languages) the changes are at Index.reindex? I can see reasons for either decision based on skimming through the class inheritance patterns.

Sorry if these are remedial questions, just want to make my limited time focused and productive while reducing review cycle tedium for you where my knowledge gaps are. I'll make decisions once I get into it either way if there's no preference, but some foresight would save some time if there are preferences.

Also sorry for the delay, too many commitments on my plate at the moment. Next step for this is to get a list of args for the test which is simple but tedious enough to conflict my schedule. If anyone wants to assist I can probably fit resolving any test failures into my schedule easier. If nobody claims that testing task I will wrap this up as soon as I can.

[WillAyd]

@ajspera you should be able to parametrize the various combinations of parameters. If you search for parametrize in the tests you should see quite a few examples to work off of

[jreback]

needs a test & a whatsnew note

[jreback]

use not len

[WillAyd]

@ajspera is this still active?

[jreback]

closing as stale; this does fix the issue but needs tests. if you want to continue, pls merge master and ping to re-open.