BUG in reindex raises IndexingError when df is empty sometimes #37874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
the
Indexing
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -584,6 +584,7 @@ Indexing | |||
| - Bug in :meth:`DataFrame.loc` returned requested key plus missing values when ``loc`` was applied to single level from :class:`MultiIndex` (:issue:`27104`) | |||
| - Bug in indexing on a :class:`Series` or :class:`DataFrame` with a :class:`CategoricalIndex` using a listlike indexer containing NA values (:issue:`37722`) | |||
| - Bug in :meth:`DataFrame.xs` ignored ``droplevel=False`` for columns (:issue:`19056`) | |||
| - Bug in :meth:`DataFrame.reindex` returns ``IndexingError`` for empty :class:`DataFrame` with ``tolerance`` not None or ``method="nearest"`` (:issue:`27315`) | |||
There was a problem hiding this comment.
is the bug that it is raising IndexingError when it shouldnt or that it isnt when it should?
returns -> raising
There was a problem hiding this comment.
wrongly raising when it should not. Changed and clarified it
| # GH#27315 | ||
| idx = date_range(start="2020", freq="30s", periods=3) | ||
| df = DataFrame([], index=Index([], name="time"), columns=["a"]) | ||
| result = df.reindex(idx, **kwargs) |
There was a problem hiding this comment.
you're testing the DataFrame.reindex method, this goes in tests.frame.methods.test_reindex
rule of thumb: if you need Series or DataFrame, it probably doesnt belong in tests.indexes
There was a problem hiding this comment.
Thx, that helps me for the future. Moved the test
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffBuild on top of #27326