CLN: Remove unused fixtures #36699
CLN: Remove unused fixtures #36699
Conversation
dsaxton
added
Testing
pandas/tests/window/conftest.py
Outdated
| @@ -42,21 +42,11 @@ def arithmetic_win_operators(request): | |||
| return request.param | |||
|
|
|||
|
|
|||
| @pytest.fixture(params=["right", "left", "both", "neither"]) | |||
| def closed(request): | |||
There was a problem hiding this comment.
as this is generally a fixture we do want
pandas/tests/window/conftest.py
Outdated
| @pytest.fixture(params=[True, False]) | ||
| def center(request): | ||
| return request.param | ||
|
|
||
|
|
||
| @pytest.fixture(params=[None, 1]) | ||
| def min_periods(request): |
There was a problem hiding this comment.
why are u removing this one?
There was a problem hiding this comment.
No special reason, was only removing if unused. Adding back these window fixtures.
pandas/tests/window/conftest.py
Outdated
| @@ -75,14 +65,6 @@ def nopython(request): | |||
| return request.param | |||
|
|
|||
|
|
|||
| @pytest.fixture( | |||
| params=[pytest.param("numba", marks=td.skip_if_no("numba", "0.46.0")), "cython"] | |||
| ) | |||
|
LGTM |
|
Does pytest expose a way to figure out what is / isn't being used? |
There's a plugin (which is what I was using here) but not sure how well-maintained it is: https://github.com/jllorencetti/pytest-deadfixtures |
|
thanks! also as a possible issue / followup. we ideally want to surface the same / similar fixtures to the top level (and similarly push down ones that are ownly used beneath a particular sub-tree to a lower level). not sure if there is an easy way to do this. |
No description provided.