-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CLN: Remove unused fixtures #36699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: Remove unused fixtures #36699
Changes from 1 commit
a957b3f
9bf0829
fa9e1f0
fd91b24
7ff5052
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,21 +42,11 @@ def arithmetic_win_operators(request): | |
return request.param | ||
|
||
|
||
@pytest.fixture(params=["right", "left", "both", "neither"]) | ||
def closed(request): | ||
return request.param | ||
|
||
|
||
@pytest.fixture(params=[True, False]) | ||
def center(request): | ||
return request.param | ||
|
||
|
||
@pytest.fixture(params=[None, 1]) | ||
def min_periods(request): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why are u removing this one? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No special reason, was only removing if unused. Adding back these window fixtures. |
||
return request.param | ||
|
||
|
||
@pytest.fixture(params=[True, False]) | ||
def parallel(request): | ||
"""parallel keyword argument for numba.jit""" | ||
|
@@ -75,14 +65,6 @@ def nopython(request): | |
return request.param | ||
|
||
|
||
@pytest.fixture( | ||
params=[pytest.param("numba", marks=td.skip_if_no("numba", "0.46.0")), "cython"] | ||
) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is also needed |
||
def engine(request): | ||
"""engine keyword argument for rolling.apply""" | ||
return request.param | ||
|
||
|
||
@pytest.fixture( | ||
params=[ | ||
pytest.param(("numba", True), marks=td.skip_if_no("numba", "0.46.0")), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this a duplicate yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this is generally a fixture we do want