BUG: __from_arrow__ not respecting explicit dtype #52547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 10, 2023
| @@ -1739,6 +1739,21 @@ def test_setitem_invalid_dtype(data): | |||
| data[:] = fill_value | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(pa_version_under8p0, reason="returns object with 7.0") | |||
| def test_from_arrow_respecting_given_dtype(): | |||
There was a problem hiding this comment.
Could you add a test for an invalid/unsafe cast as well?
mroeschke
reviewed
Apr 10, 2023
pandas/core/arrays/arrow/dtype.py
Outdated
| @@ -319,4 +320,5 @@ def __from_arrow__(self, array: pa.Array | pa.ChunkedArray): | |||
| Construct IntegerArray/FloatingArray from pyarrow Array/ChunkedArray. | |||
| """ | |||
| array_class = self.construct_array_type() | |||
| return array_class(array) | |||
| arr = pc.cast(array, self.pyarrow_dtype, safe=True) | |||
There was a problem hiding this comment.
Nit: Could just do array.cast(self.pyarrow_dtype, safe=True)
mroeschke
approved these changes
Apr 10, 2023
mroeschke
approved these changes
Apr 10, 2023
|
Thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 10, 2023
mroeschke
pushed a commit
that referenced
this pull request
Apr 11, 2023
…g explicit dtype) (#52584) Backport PR #52547: BUG: __from_arrow__ not respecting explicit dtype Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__from_arrow__ignores its dtype but converts data to its mapped ArrowDtype #52533 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @mroeschke thoughts?