Skip to content

BUG: __from_arrow__ not respecting explicit dtype #52547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2023
Merged

BUG: __from_arrow__ not respecting explicit dtype #52547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be34e24
BUG: __from_arrow__ not respecting explicit dtype
phofl Apr 8, 2023
b790dcc
Skip for arrow 7
phofl Apr 9, 2023
803561d
Add test
phofl Apr 10, 2023
66e47e2
Remove skip
phofl Apr 10, 2023
84332de
Skip
phofl Apr 10, 2023
64ebd8a
Skip
phofl Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v2.0.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Bug fixes
- Bug in :meth:`Series.describe` not returning :class:`ArrowDtype` with ``pyarrow.float64`` type with numeric data (:issue:`52427`)
- Fixed segfault in :meth:`Series.to_numpy` with ``null[pyarrow]`` dtype (:issue:`52443`)
- Bug in :func:`pandas.testing.assert_series_equal` where ``check_dtype=False`` would still raise for datetime or timedelta types with different resolutions (:issue:`52449`)
- Bug in :meth:`ArrowDtype.__from_arrow__` not respecting if dtype is explicitly given (:issue:`52533`)

.. ---------------------------------------------------------------------------
.. _whatsnew_201.other:
Expand Down
3 changes: 2 additions & 1 deletion pandas/core/arrays/arrow/dtype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,4 +319,5 @@ def __from_arrow__(self, array: pa.Array | pa.ChunkedArray):
Construct IntegerArray/FloatingArray from pyarrow Array/ChunkedArray.
"""
array_class = self.construct_array_type()
return array_class(array)
arr = array.cast(self.pyarrow_dtype, safe=True)
return array_class(arr)
22 changes: 22 additions & 0 deletions pandas/tests/extension/test_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,6 +1739,28 @@ def test_setitem_invalid_dtype(data):
data[:] = fill_value


@pytest.mark.skipif(pa_version_under8p0, reason="returns object with 7.0")
def test_from_arrow_respecting_given_dtype():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for an invalid/unsafe cast as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a test

date_array = pa.array(
[pd.Timestamp("2019-12-31"), pd.Timestamp("2019-12-31")], type=pa.date32()
)
result = date_array.to_pandas(
types_mapper={pa.date32(): ArrowDtype(pa.date64())}.get
)
expected = pd.Series(
[pd.Timestamp("2019-12-31"), pd.Timestamp("2019-12-31")],
dtype=ArrowDtype(pa.date64()),
)
tm.assert_series_equal(result, expected)


@pytest.mark.skipif(pa_version_under8p0, reason="doesn't raise with 7")
def test_from_arrow_respecting_given_dtype_unsafe():
array = pa.array([1.5, 2.5], type=pa.float64())
with pytest.raises(pa.ArrowInvalid, match="Float value 1.5 was truncated"):
array.to_pandas(types_mapper={pa.float64(): ArrowDtype(pa.int64())}.get)


def test_round():
dtype = "float64[pyarrow]"

Expand Down