refactor: bump UUID dep, remove 'deep require' of uuid #1492
Conversation
Thanks for opening this pull request!
|
jpgupta
changed the title
jpgupta
changed the title
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
|
Could you take a look at the failing tests? |
|
@mtrezza Yes I'll take a look this week
|
|
Maybe rebasing this PR on alpha fixes this, see #1495. |
|
@mtrezza I'll give that a go thank you! |
|
It seems the package-lock file still has a conflict |
|
@mtrezza - taking a look |
|
@mtrezza - I'm seeing this message, could you kindly re-run this workflow? |
|
Did you recreate the package-lock file? 26,671 additions, 165 deletions looks unusual for this simple dependency upgrade. |
|
@jpgupta Could you use the package-lock file from the alpha branch and do the dependency upgrade again? |
|
@mtrezza sorry for the delay, bunch of things going on - will take a look at this in the next few days |
## [3.4.3-alpha.3](parse-community/Parse-SDK-JS@3.4.3-alpha.2...3.4.3-alpha.3) (2022-07-02) ### Bug Fixes * subscription to a LiveQuery containing `ParseQuery.select` overrides properties ([parse-community#1488](parse-community#1488)) ([b80eee4](parse-community@b80eee4))
## [3.4.3](parse-community/Parse-SDK-JS@3.4.2...3.4.3) (2022-07-02) ### Bug Fixes * creating a Parse.File with base64 string fails for some file types ([parse-community#1467](parse-community#1467)) ([c07d6c9](parse-community@c07d6c9)) * invalid name for `Parse.Role` throws incorrect error ([parse-community#1481](parse-community#1481)) ([8326a6f](parse-community@8326a6f))
## [3.4.4-beta.1](parse-community/Parse-SDK-JS@3.4.3...3.4.4-beta.1) (2022-07-02) ### Bug Fixes * subscription to a LiveQuery containing `ParseQuery.select` overrides properties ([parse-community#1488](parse-community#1488)) ([b80eee4](parse-community@b80eee4))
jpgupta
force-pushed
the
update-uuid-dep
branch
from
ef2aad3 to
85cfa08
Compare
|
Closing for bot to recreate PR. |
See UUID documentation - https://github.com/uuidjs/uuid#deep-requires-now-deprecated
New Pull Request Checklist
Issue Description
The way Parse requires the uuid package is discouraged by the maintainers, and seems to be causing issues with other dependencies in my project.
Related issue:
#1491
Approach
This PR updates the uuid dependency fro 3x to 8x, and modifies the way it is imported/required, to use a named import, instead of the deprecated deep require appraoch.
I am not an expert in the nuances of JS import/require approaches so would appreciate some input from someone on this change -it seems to be sensible to me and in line with what the uuid project maintainers recommend (https://github.com/uuidjs/uuid#deep-requires-now-deprecated).
TODOs before merging