-
-
Notifications
You must be signed in to change notification settings - Fork 598
fix: Uuid on AnonymousUtils.js #1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR fix this error : Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './v4' is not defined by "exports" in /PATH/node_modules/uuid/package.json at new NodeError (node:internal/errors:400:5) at exportsNotFound (node:internal/modules/esm/resolve:361:10) at packageExportsResolve (node:internal/modules/esm/resolve:697:9) at resolveExports (node:internal/modules/cjs/loader:538:36) at Module._findPath (node:internal/modules/cjs/loader:607:31) at Module._resolveFilename (node:internal/modules/cjs/loader:1025:27) at Module._load (node:internal/modules/cjs/loader:885:27) at Module.require (node:internal/modules/cjs/loader:1105:19) at require (node:internal/modules/cjs/helpers:103:18) at Object.<anonymous> (/PATH/node_modules/parse/lib/node/AnonymousUtils.js:27:16) { code: 'ERR_PACKAGE_PATH_NOT_EXPORTED' }
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request!
|
Codecov ReportBase: 99.89% // Head: 99.89% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## alpha #1650 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 61 61
Lines 5973 5973
Branches 1367 1367
=======================================
Hits 5967 5967
Misses 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I don't know why it's not passing the tests on 16.18.1, all I know is that the official version was not working on my 18.13 version, and with my fix now it works. |
This is probably just a flaky test. Could you add a test that demonstrates the issue? The CI is testing with Node 18.12.1 and all tests pass also without this fix. So we'd need to see why this doesn't work. Could you please also open an issue for this PR - it asks for fundamental infos that help to analyze the issue. |
@Hayrudz I believe this PR is a better fix just needs some clean up. Can you see if it fixes your issue. |
Closing in favor of #1582 |
@dplewis the PR #1582 is doing the same thing than me but in a different file, and also do few other changes so I can't tell. |
New Pull Request Checklist
Issue Description
Closes: #1491
This PR fix this error :
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './v4' is not defined by "exports" in /PATH/node_modules/uuid/package.json
at new NodeError (node:internal/errors:400:5)
at exportsNotFound (node:internal/modules/esm/resolve:361:10)
at packageExportsResolve (node:internal/modules/esm/resolve:697:9)
at resolveExports (node:internal/modules/cjs/loader:538:36)
at Module._findPath (node:internal/modules/cjs/loader:607:31)
at Module._resolveFilename (node:internal/modules/cjs/loader:1025:27)
at Module._load (node:internal/modules/cjs/loader:885:27)
at Module.require (node:internal/modules/cjs/loader:1105:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/PATH/node_modules/parse/lib/node/AnonymousUtils.js:27:16) {
code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}
Approach
TODOs before merging