This repository was archived by the owner on Jun 13, 2023. It is now read-only.
Lock dependencies' versions and Bump Bolts-Swift to 1.2.0 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, none of the dependencies had their version locked in either the .podspec or Podfile. So, if one of them got updated with breaking changes then building would ouviously break after a `pod update`. This issue happened recently when Bolts-Swift was updated with breaking changes from 1.1.0 to 1.2.0. This addresses that by locking the dependency versions to the latest compatible version at the moment. When support is added to the new dependency versions, the podspec/Podfile should be updated and the pod version should be bumped.
- Updated Bolts-Swift to 1.2.0 in the .podspec and Podfile - Updated BoltsHelpers.swift to use the new `TaskCompletionSource` API - Fixed warning for using `typealias` when `associatedtype` should be used
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
ghost
added
the
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock CocoaPods dependencies' versions
Until now, none of the dependencies had their version locked in either
the .podspec or Podfile. So, if one of them got updated with breaking
changes then building would ouviously break after a
pod update.This issue happened recently when Bolts-Swift was updated with breaking
changes from 1.1.0 to 1.2.0.
This addresses that by locking the dependency versions to the latest
compatible version at the moment. When support is added to the new
dependency versions, the podspec/Podfile should be updated and the pod
version should be bumped.
Bump Bolts-Swift to 1.2.0
TaskCompletionSourceAPItypealiaswhenassociatedtypeshould beused