Skip to content

Enabling audiences UI #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Conversation

davimacedo
Copy link
Member

@natanrolnik
Copy link
Contributor

This is a great feature to have, thanks for the contribution, @davimacedo!
@flovilmart, could you review this and the PR for the server?

@flovilmart
Copy link
Contributor

Thanks @davimacedo for the feature, can you address the lint errors. Also, I'd prefer we kept the method calls on one line, this is hardly readable that way for ex:

const path = action.limit ? `push_audiences?audience_limit=${action.limit}` : 'push_audiences';
const options = {useMasterKey: true}
let promise = action.app.apiRequest('GET', path, {}, options)

Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you address the stylistic nits before we get that one in? (and also the lint error)

@davimacedo
Copy link
Member Author

Done.

"appId": "",
"masterKey": "",
"appName": "",
"serverURL": "https://parseapi.back4app.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry... at least it was a test app :)

@natanrolnik
Copy link
Contributor

natanrolnik commented Jun 21, 2017

Please fix the config.json and we will merge it! Also, if you could rebase and add this to the changelog, would be perfect.

@davimacedo
Copy link
Member Author

done

@natanrolnik natanrolnik merged commit 181519c into parse-community:master Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants