-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Enabling audiences UI #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a great feature to have, thanks for the contribution, @davimacedo! |
Thanks @davimacedo for the feature, can you address the lint errors. Also, I'd prefer we kept the method calls on one line, this is hardly readable that way for ex:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you address the stylistic nits before we get that one in? (and also the lint error)
Done. |
"appId": "", | ||
"masterKey": "", | ||
"appName": "", | ||
"serverURL": "https://parseapi.back4app.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry... at least it was a test app :)
Please fix the config.json and we will merge it! Also, if you could rebase and add this to the changelog, would be perfect. |
done |
See parse-community/parse-server#3861