Skip to content

Fix Databrowser shows correct count of filtered objects #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

engel
Copy link
Contributor

@engel engel commented Jan 28, 2018

No description provided.

@montymxb
Copy link
Contributor

montymxb commented Feb 1, 2018

@engel can you elaborate on this? .length should suffice...

@engel
Copy link
Contributor Author

engel commented Feb 1, 2018

After upgrading to parse-dashboard 1.1.2 from 1.0.28 I found that after filtering a table, the object count was not calculated correctly anymore. See screenshot.

bildschirmfoto 2018-02-01 um 22 31 19

This PR fixes this by using List.size instead of List.length (as List.length is not defined in the List (Collection) class of the immutable package)

Additionally I found that v1.0.28 includes the "immutable": "~3.7.5" package while v1.1.2 uses "immutable": "~3.8.1".
I assume that changes to the immutable package are the reason why filters.length not work anymore.

@montymxb
Copy link
Contributor

montymxb commented Feb 1, 2018

@engel just confirmed this, and went to their docs and found size listed there. I did not find any reference to length however, not sure if that ever was a valid member or not.

Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: approved! Nice catch on this one.

@montymxb montymxb merged commit bcf8c41 into parse-community:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants