Skip to content

Fix Databrowser shows correct count of filtered objects #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Fix Databrowser shows correct count of filtered objects #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* _Contributing to this repo? Add info about your change here to be included in next release_
* Fix: Filtering with a 1-digit number (#831), thanks to [Pascal Giguère](https://github.com/pgiguere1)
* Fix: Databrowser shows correct count of filtered objects, thanks to [Tom Engelbrecht](https://github.com/engel)

### 1.1.2

Expand Down
2 changes: 1 addition & 1 deletion src/dashboard/Data/Browser/Browser.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ export default class Browser extends DashboardView {
async fetchData(source, filters = new List()) {
const data = await this.fetchParseData(source, filters);
var filteredCounts = { ...this.state.filteredCounts };
if (filters.length > 0) {
if (filters.size > 0) {
filteredCounts[source] = await this.fetchParseDataCount(source,filters);
} else {
delete filteredCounts[source];
Expand Down