Skip to content

Make beforeSave work when object is passed to success #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions spec/ParseAPI.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,27 @@ describe('miscellaneous', function() {
done();
});
});
it('works when object is passed to success', done => {
let triggerTime = 0;
// Register a mock beforeSave hook
Parse.Cloud.beforeSave('GameScore', (req, res) => {
let object = req.object;
object.set('foo', 'bar');
triggerTime++;
res.success(object);
});

let obj = new Parse.Object('GameScore');
obj.set('foo', 'baz');
obj.save().then(() => {
expect(triggerTime).toBe(1);
expect(obj.get('foo')).toEqual('bar');
done();
}, error => {
fail(error);
done();
});
});

it('original object is set on update', done => {
let triggerTime = 0;
Expand Down
3 changes: 2 additions & 1 deletion src/triggers.js
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ export function getResponseObject(request, resolve, reject) {
return {
success: function(response) {
// Use the JSON response
if (response && request.triggerName === Types.beforeSave) {
if (response && !request.object.equals(response)
&& request.triggerName === Types.beforeSave) {
return resolve(response);
}
response = {};
Expand Down