Require a server URL #608
Merged
Require a server URL #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +82,7 @@ function ParseServer({ | |||
| facebookAppIds = [], | |||
| enableAnonymousUsers = true, | |||
| oauth = {}, | |||
| serverURL = '', | |||
| serverURL = (()=>{throw 'You must provide a serverURL!'})(), | |||
There was a problem hiding this comment.
let's use the same pattern on appId and masterKey then no?
There was a problem hiding this comment.
Sure, I don't see why not. I might actually give this pattern a name to make it more clear.
There was a problem hiding this comment.
Too bad we can't use '!!' as a function name. notOptional("serverURL"), required is confusing, compulsory too long, provided sounds weird,
|
@drew-gross updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
drew-gross
force-pushed
the
throw-no-server-url
branch
from
45be5cd to
1a405a0
Compare
|
@drew-gross updated the pull request. |
|
Squash and merge? Love the 2 liners :) |
drew-gross
force-pushed
the
throw-no-server-url
branch
from
1a405a0 to
2dc080f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw at launch if no server url is provided. Hopefully this will reduce the number of issues that are opened.