use service locator for configured client strategy #185
+123
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Jul 12, 2017
Nyholm
approved these changes
Jul 13, 2017
|
|
||
| $this->assertEquals($container->get('httplug.client.acme'), NSA::getProperty($strategy, 'client')); | ||
| $this->assertEquals($container->get('httplug.client.acme'), NSA::getProperty($strategy, 'asyncClient')); | ||
| $this->assertEquals($container->get('httplug.client.acme'), ConfiguredClientsStrategy::getCandidates(HttpClient::class)[0]['class']()); |
There was a problem hiding this comment.
This is not proper PHP 5 code.
$foo = ConfiguredClientsStrategy::getCandidates(HttpClient::class)[0]['class'];
$foo();
When available (Symfony 3.3+), a ServiceLocator is used in the ConfiguredClientStrategy to lazy load discoverable clients. A fallback injecting the Container is implemented for older Symfony versions.
|
Thank you for reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
When available (Symfony 3.3+), a
ServiceLocatoris used in theConfiguredClientStrategyto lazy load discoverable clients. A fallback injecting the Container is implemented for older Symfony versions.Why?
This is required to solve a chicken/egg problem for #109. This should also improve a few resources usage by only building clients when discovery is called (before discovered clients were built at
kernel.requestorconsole.command).