Add test for Artax. #30
Conversation
.travis.yml
Outdated
| @@ -10,6 +10,7 @@ php: | |||
| 5.5 | |||
There was a problem hiding this comment.
Artax is PHP 7+ only, so either you need to update everything to test on 7.0 or just modify the PHP version for Artax.
There was a problem hiding this comment.
We cannot modify the PHP version on the Artax adapter because amphp/artax is php 7.0 only: https://github.com/amphp/artax/blob/master/composer.json
Lets run all the tests on PHP7.
There was a problem hiding this comment.
Right, all amphp/* packages are 7.0 only, because we require features like return for generators. I didn't mean changing artax-adapter, but the PHP version used only for that, e.g. with matrix + include: https://docs.travis-ci.com/user/customizing-the-build#Explicitly-included-jobs-inherit-the-first-value-in-the-array
There was a problem hiding this comment.
But testing everything on 7.0 is also fine.
|
The changed PHP version installs PHPUnit 6 now, which makes Guzzle5 tests fail. |
|
Okey. thanks! |
No description provided.