Skip to content

Add test for Artax. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add test for Artax. #30

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b40b4ef
Updated the number of tests
Nyholm Jul 10, 2017
bc86e76
Added Artax test suite
Nyholm Jul 10, 2017
52c4837
Update .travis.yml
Nyholm Jul 10, 2017
9eaee1b
Run tests on PHP7
Nyholm Jul 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ php:
5.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artax is PHP 7+ only, so either you need to update everything to test on 7.0 or just modify the PHP version for Artax.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot modify the PHP version on the Artax adapter because amphp/artax is php 7.0 only: https://github.com/amphp/artax/blob/master/composer.json

Lets run all the tests on PHP7.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, all amphp/* packages are 7.0 only, because we require features like return for generators. I didn't mean changing artax-adapter, but the PHP version used only for that, e.g. with matrix + include: https://docs.travis-ci.com/user/customizing-the-build#Explicitly-included-jobs-inherit-the-first-value-in-the-array

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But testing everything on 7.0 is also fine.


env:
- SUITE="Artax" PACKAGE="php-http/artax-adapter:dev-master"
- SUITE="curl" PACKAGE="php-http/curl-client:dev-master zendframework/zend-diactoros"
- SUITE="Socket" PACKAGE="php-http/socket-client:dev-master php-http/client-common"
- SUITE="Guzzle5" PACKAGE="php-http/guzzle5-adapter:dev-master"
Expand Down
3 changes: 3 additions & 0 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit colors="true" bootstrap="vendor/autoload.php">
<testsuites>
<testsuite name="Artax">
<directory>vendor/php-http/artax-adapter/tests</directory>
</testsuite>
<testsuite name="curl">
<directory>vendor/php-http/curl-client/tests</directory>
</testsuite>
Expand Down