Improve package #76
Improve package #76
Conversation
sagikazarmark
force-pushed
the
improve_package
branch
2 times, most recently
from
df55482 to
53e02fa
Compare
|
Okay, so this PR improves some package files, fixes styleci config AND removes the puli binary as discussed in #48. Please review. |
sagikazarmark
force-pushed
the
improve_package
branch
from
53e02fa to
7532cb0
Compare
| @@ -1 +0,0 @@ | |||
| Please see http://docs.php-http.org/en/latest/development/contributing.html | |||
There was a problem hiding this comment.
This means that GitHub does not show this "warning" anymore.
There was a problem hiding this comment.
It is moved to .github
There was a problem hiding this comment.
Sorry, I did not know you could put it there. All good then!
sagikazarmark
force-pushed
the
improve_package
branch
from
7532cb0 to
ceb36a8
Compare
|
Okay, need someone else too to review this as the final PR before tagging a stable. /cc @dbu |
| }, | ||
| "require-dev": { | ||
| "php-http/httplug": "^1.0", | ||
| "php-http/message-factory": "^1.0", | ||
| "puli/composer-plugin": "1.0.0-beta9", | ||
| "puli/composer-plugin": "1.0.0-beta9 || 1.0.0-beta10", |
There was a problem hiding this comment.
this is dev dependency anyways, do we need to allow multiple versions?
There was a problem hiding this comment.
i merged anyways, as this is really not important. if you want to change it, plesae do. otherwise i think it does no harm.
There was a problem hiding this comment.
Indeed. Should we add conflict field saying these are the only supported versions?
There was a problem hiding this comment.
I do not think so. It is in the docs. (My BC pr)
If we want to do this properly we should config Travis to run tests with different versions of puli.
There was a problem hiding this comment.
we could mention it in the suggest section. i would not add conflicts.
There was a problem hiding this comment.
No description provided.