Fix BC break #33
Merged
Fix BC break #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @nenadstojanovikj do you have time to look at the travis-ci build failures ? As we are using some methods from |
|
I updated some more deps since build was still failing because of |
joelwurtz
approved these changes
Sep 17, 2018
|
@joelwurtz Could this be merged? |
|
@nenadstojanovikj Thanks a lot for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds a workaround for missing
LoopInterface::tick()method.Why?
Since
react/http-clientutilizes newer versions ofreact/event-loopwhich have BC in them, thetick()method no longer exists. This PR adds a workaround to fix that.Example Usage
Checklist