-
Notifications
You must be signed in to change notification settings - Fork 106
Fix various width issues #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…med to have changed from the default. Special case menu shrinking.
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
============================================
+ Coverage 93.01% 93.02% +<.01%
- Complexity 591 606 +15
============================================
Files 30 31 +1
Lines 1761 1791 +30
============================================
+ Hits 1638 1666 +28
- Misses 123 125 +2
Continue to review full report at Codecov.
|
@jtreminio could you make some tests with PR see if it fixes your problems? |
This is almost perfect, but the margin is being applied only to left-side: I've highlighted the scrollbar area on my terminal: This is with your patch of
|
That was the wrong fix actually, it's all related to shrinking the menu width when the terminal is too narrow. Regarding the right margin, yeah we actually don't ever print that because it's obviously empty space, so it never got handled when the terminal is too narrow. Will implement that in another PR. |
Hopefully this should fix #219. This has taken me all day to fix 😭
Also adds a few utils, debug mode for menu style and mock terminal class for tests.
Going to add a few more tests for the changes regarding width and margins.