Skip to content

Upgrade phpstan and fix issues #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2019
Merged

Upgrade phpstan and fix issues #221

merged 1 commit into from
Dec 24, 2019

Conversation

AydinHassan
Copy link
Member

Rebase after #220 and renable phpstan on travis

@codecov-io
Copy link

codecov-io commented Dec 22, 2019

Codecov Report

Merging #221 into master will increase coverage by 0.04%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #221      +/-   ##
============================================
+ Coverage     93.01%   93.06%   +0.04%     
+ Complexity      591      590       -1     
============================================
  Files            30       30              
  Lines          1761     1759       -2     
============================================
- Hits           1638     1637       -1     
+ Misses          123      122       -1
Impacted Files Coverage Δ Complexity Δ
src/Exception/InvalidShortcutException.php 0% <0%> (ø) 1 <0> (ø) ⬇️
src/Input/InputIO.php 96.87% <100%> (ø) 25 <1> (ø) ⬇️
src/Builder/CliMenuBuilder.php 77.17% <100%> (ø) 89 <18> (ø) ⬇️
src/MenuStyle.php 97.17% <100%> (+0.37%) 63 <3> (-1) ⬇️
src/CliMenu.php 95.34% <100%> (ø) 115 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1316f37...554883f. Read the comment docs.

@AydinHassan AydinHassan merged commit 0283b18 into master Dec 24, 2019
@AydinHassan AydinHassan deleted the upgrade-phpstan branch February 15, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants