Skip to content

Drop PHP 7.0 and 5.x support #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 16, 2018
Merged

Drop PHP 7.0 and 5.x support #79

merged 11 commits into from
Apr 16, 2018

Conversation

AydinHassan
Copy link
Member

@AydinHassan AydinHassan commented Apr 16, 2018

  • Minimum PHP version now 7.1
  • Updated dependencies
  • Remove useless @package + Class doc blocks
  • Add type hints everywhere and removed useless assertions + remove doc block hints
  • Added phpstan to build

@AydinHassan AydinHassan requested a review from mikeymike April 16, 2018 09:35
@codecov-io
Copy link

codecov-io commented Apr 16, 2018

Codecov Report

Merging #79 into master will increase coverage by 0.55%.
The diff coverage is 89.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
+ Coverage     88.57%   89.13%   +0.55%     
- Complexity      241      246       +5     
============================================
  Files            18       18              
  Lines           735      690      -45     
============================================
- Hits            651      615      -36     
+ Misses           84       75       -9
Impacted Files Coverage Δ Complexity Δ
src/Action/ExitAction.php 100% <100%> (ø) 1 <1> (ø) ⬇️
src/MenuItem/SelectableItem.php 100% <100%> (ø) 4 <4> (+1) ⬆️
src/MenuItem/LineBreakItem.php 100% <100%> (ø) 9 <9> (+1) ⬆️
src/Dialogue/Confirm.php 100% <100%> (ø) 2 <2> (ø) ⬇️
src/MenuItem/MenuMenuItem.php 100% <100%> (ø) 5 <5> (+1) ⬆️
src/Util/StringUtil.php 100% <100%> (ø) 5 <5> (ø) ⬇️
src/Dialogue/Flash.php 100% <100%> (ø) 1 <1> (ø) ⬇️
src/Action/GoBackAction.php 100% <100%> (ø) 2 <2> (ø) ⬇️
src/CliMenuBuilder.php 98.55% <100%> (-0.16%) 43 <39> (-2)
src/MenuItem/AsciiArtItem.php 100% <100%> (ø) 13 <9> (+1) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8c472...cf8be6a. Read the comment docs.

@AydinHassan AydinHassan mentioned this pull request Apr 16, 2018
@mikeymike
Copy link
Member

woop

@AydinHassan AydinHassan merged commit 6270594 into master Apr 16, 2018
@AydinHassan AydinHassan deleted the upgrade-php-7.1 branch April 16, 2018 19:16
@AydinHassan AydinHassan added this to the 3.0 milestone May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants